lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y38UQXbzw54Jo93s@atomide.com> Date: Thu, 24 Nov 2022 08:50:41 +0200 From: Tony Lindgren <tony@...mide.com> To: Andy Shevchenko <andriy.shevchenko@...el.com> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, Jiri Slaby <jirislaby@...nel.org>, Johan Hovold <johan@...nel.org>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Vignesh Raghavendra <vigneshr@...com>, linux-serial@...r.kernel.org, linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 2/2] serial: core: Add port port device to flush TX on runtime resume Hi, Thanks for your review again, will fix what you noted. One idea for an improvment below though. * Andy Shevchenko <andriy.shevchenko@...el.com> [221123 18:37]: > On Wed, Nov 23, 2022 at 10:28:25AM +0200, Tony Lindgren wrote: > > +EXPORT_SYMBOL(serial_port_get); > > Can we move these to namespace from day 1? Assuming you mean EXPORT_SYMBOL_NS(), sure. But we might be better off doing the following: - Move already exported uart_add_one_port() and uart_remove_one_port() from serial_core to serial_port as wrapper functions for serial_core - Export new functions in serial_core for serial_core_register_port() and serial_core_unregister_port() for serial_port to call This would ensure both serial_core and serial_port modules are always loaded when a hardware specific serial port driver is loaded. This should also leave out the need for serial_port_get() and serial_port_put(). Regards, Tony
Powered by blists - more mailing lists