linux-kernel - Re: [PATCH] dt-bindings: media: amphion: use hyphen in node name of vpu core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7213be47-1746-b7c6-9807-21865adc190a@xs4all.nl>
Date:   Thu, 24 Nov 2022 09:48:58 +0100
From:   Hans Verkuil <hverkuil-cisco@...all.nl>
To:     Ming Qian <ming.qian@....com>, mchehab@...nel.org,
        shawnguo@...nel.org
Cc:     robh+dt@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com, aisheng.dong@....com,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-devicetree <devicetree@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: media: amphion: use hyphen in node name of
 vpu core

Rob, can you Ack (or nack) this old patch? It looks like it was
missed, most likely because the devicetree ML wasn't CCed.

Regards,

	Hans

On 11/04/2022 09:48, Ming Qian wrote:
> Hyphen is recommended in node name than underscore.
> So change the node name from "vpu_core" to "vpu-core"
> 
> Signed-off-by: Ming Qian <ming.qian@....com>
> ---
>  Documentation/devicetree/bindings/media/amphion,vpu.yaml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/amphion,vpu.yaml b/Documentation/devicetree/bindings/media/amphion,vpu.yaml
> index a9d80eaeeeb6..c0d83d755239 100644
> --- a/Documentation/devicetree/bindings/media/amphion,vpu.yaml
> +++ b/Documentation/devicetree/bindings/media/amphion,vpu.yaml
> @@ -47,7 +47,7 @@ patternProperties:
>      $ref: ../mailbox/fsl,mu.yaml#
>  
>  
> -  "^vpu_core@[0-9a-f]+$":
> +  "^vpu-core@[0-9a-f]+$":
>      description:
>        Each core correspond a decoder or encoder, need to configure them
>        separately. NXP i.MX8QM SoC has one decoder and two encoder, i.MX8QXP SoC
> @@ -143,7 +143,7 @@ examples:
>          power-domains = <&pd IMX_SC_R_VPU_MU_2>;
>        };
>  
> -      vpu_core0: vpu_core@...80000 {
> +      vpu_core0: vpu-core@...80000 {
>          compatible = "nxp,imx8q-vpu-decoder";
>          reg = <0x2d080000 0x10000>;
>          power-domains = <&pd IMX_SC_R_VPU_DEC_0>;
> @@ -154,7 +154,7 @@ examples:
>          memory-region = <&decoder_boot>, <&decoder_rpc>;
>        };
>  
> -      vpu_core1: vpu_core@...90000 {
> +      vpu_core1: vpu-core@...90000 {
>          compatible = "nxp,imx8q-vpu-encoder";
>          reg = <0x2d090000 0x10000>;
>          power-domains = <&pd IMX_SC_R_VPU_ENC_0>;
> @@ -165,7 +165,7 @@ examples:
>          memory-region = <&encoder1_boot>, <&encoder1_rpc>;
>        };
>  
> -      vpu_core2: vpu_core@...a0000 {
> +      vpu_core2: vpu-core@...a0000 {
>          reg = <0x2d0a0000 0x10000>;
>          compatible = "nxp,imx8q-vpu-encoder";
>          power-domains = <&pd IMX_SC_R_VPU_ENC_1>;