linux-kernel - [PATCH] scsi:aic94xx: Fix self assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20221124092605.1677082-1-konstantin.meskhidze@huawei.com>
Date:   Thu, 24 Nov 2022 17:26:05 +0800
From:   Konstantin Meskhidze <konstantin.meskhidze@...wei.com>
To:     <jejb@...ux.ibm.com>
CC:     <martin.petersen@...cle.com>, <damien.lemoal@....com>,
        <john.garry@...wei.com>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <yusongping@...wei.com>,
        <hukeping@...wei.com>, <artem.kuzin@...wei.com>
Subject: [PATCH] scsi:aic94xx: Fix self assignment

This commit fixes self assignment of scb->ssp_task.retry_count
in asd_build_ssp_asc() function.

Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@...wei.com>
---
 drivers/scsi/aic94xx/aic94xx_task.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/aic94xx/aic94xx_task.c b/drivers/scsi/aic94xx/aic94xx_task.c
index ed119a3f6f2e..5a588e9f7d0a 100644
--- a/drivers/scsi/aic94xx/aic94xx_task.c
+++ b/drivers/scsi/aic94xx/aic94xx_task.c
@@ -493,7 +493,7 @@ static int asd_build_ssp_ascb(struct asd_ascb *ascb, struct sas_task *task,
 	scb->ssp_task.conn_handle = cpu_to_le16(
 		(u16)(unsigned long)dev->lldd_dev);
 	scb->ssp_task.data_dir = data_dir_flags[task->data_dir];
-	scb->ssp_task.retry_count = scb->ssp_task.retry_count;
+	scb->ssp_task.retry_count = task->ssp_task.retry_count;
 
 	ascb->tasklet_complete = asd_task_tasklet_complete;
 
-- 
2.25.1