linux-kernel - Re: [PATCH] f2fs: set zstd compress level correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8BB6F23D-6BC3-4B5A-BA94-9B8A4C58BC92@fb.com>
Date:   Thu, 24 Nov 2022 00:55:01 +0000
From:   Nick Terrell <terrelln@...a.com>
To:     Sheng Yong <shengyong@...o.com>
CC:     "jaegeuk@...nel.org" <jaegeuk@...nel.org>,
        "chao@...nel.org" <chao@...nel.org>,
        "linux-f2fs-devel@...ts.sourceforge.net" 
        <linux-f2fs-devel@...ts.sourceforge.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] f2fs: set zstd compress level correctly



> On Nov 17, 2022, at 7:10 AM, Sheng Yong <shengyong@...o.com> wrote:
> 
> > 
> Fixes: cf30f6a5f0c6 ("lib: zstd: Add kernel-specific API")
> Signed-off-by: Sheng Yong <shengyong@...o.com>
> ---
> fs/f2fs/compress.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
> index d315c2de136f2..74d3f2d2271f3 100644
> --- a/fs/f2fs/compress.c
> +++ b/fs/f2fs/compress.c
> @@ -346,7 +346,7 @@ static int zstd_init_compress_ctx(struct compress_ctx *cc)
> 	if (!level)
> 		level = F2FS_ZSTD_DEFAULT_CLEVEL;
> 
> -	params = zstd_get_params(F2FS_ZSTD_DEFAULT_CLEVEL, cc->rlen);
> +	params = zstd_get_params(level, cc->rlen);
> 	workspace_size = zstd_cstream_workspace_bound(&params.cParams);
> 
> 	workspace = f2fs_kvmalloc(F2FS_I_SB(cc->inode),
> -- 
> 2.25.1
> 

Thanks for the patch, and sorry for introducing the bug!
Looks like I missed this while rebasing that patch series.

Reviewed-by: Nick Terrell <terrelln@...com>