lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y39Lxn/6G35C0LVu@FVFF77S0Q05N> Date: Thu, 24 Nov 2022 10:47:34 +0000 From: Mark Rutland <mark.rutland@....com> To: Ren Zhijie <renzhijie2@...wei.com> Cc: catalin.marinas@....com, will@...nel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, yusongping@...wei.com Subject: Re: [PATCH v2] arm64: armv8_deprecated: fix unused-function error On Thu, Nov 24, 2022 at 02:24:29AM +0000, Ren Zhijie wrote: > If CONFIG_SWP_EMULATION is not set and > CONFIG_CP15_BARRIER_EMULATION is not set, > aarch64-linux-gnu complained about unused-function : > > arch/arm64/kernel/armv8_deprecated.c:67:21: error: ‘aarch32_check_condition’ defined but not used [-Werror=unused-function] > static unsigned int aarch32_check_condition(u32 opcode, u32 psr) > ^~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > To fix this warning, modify aarch32_check_condition() with __maybe_unused. > > Fixes: 0c5f416219da ("arm64: armv8_deprecated: move aarch32 helper earlier") > Signed-off-by: Ren Zhijie <renzhijie2@...wei.com> Acked-by: Mark Rutland <mark.rutland@....com> Mark. > --- > Changes in v2: > - modify aarch32_check_condition() with __maybe_unused. > > arch/arm64/kernel/armv8_deprecated.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c > index ed0788cf6bbb..8a9052cf3013 100644 > --- a/arch/arm64/kernel/armv8_deprecated.c > +++ b/arch/arm64/kernel/armv8_deprecated.c > @@ -64,7 +64,7 @@ struct insn_emulation { > > #define ARM_OPCODE_CONDITION_UNCOND 0xf > > -static unsigned int aarch32_check_condition(u32 opcode, u32 psr) > +static unsigned int __maybe_unused aarch32_check_condition(u32 opcode, u32 psr) > { > u32 cc_bits = opcode >> 28; > > -- > 2.17.1 >
Powered by blists - more mailing lists