linux-kernel - Re: [PATCH V2 3/3] arm_scpi: Rev last modify to support acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221124111450.mqfpmatba6f7pap6@bogus>
Date:   Thu, 24 Nov 2022 11:14:50 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     Wang Honghui <honghui.wang@...s.com.cn>
Cc:     Cristian Marussi <cristian.marussi@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 3/3] arm_scpi: Rev last modify to support acpi

On Thu, Nov 24, 2022 at 05:59:47PM +0800, Wang Honghui wrote:
> Rev last modify to support acpi
> 
> Signed-off-by: Wang Honghui <honghui.wang@...s.com.cn>
> ---
>  drivers/firmware/arm_scpi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c
> index e2e90dcc38bd..aca0a9780c12 100644
> --- a/drivers/firmware/arm_scpi.c
> +++ b/drivers/firmware/arm_scpi.c
> @@ -908,7 +908,9 @@ static const struct of_device_id shmem_of_match[] __maybe_unused = {
>  	{ }
>  };
>  
> +#ifdef CONFIG_PHYTIUM_MBOX
>  extern struct mbox_chan *phytium_mbox_request_channel(struct mbox_client *cl);
> +#endif

I have already NACK the approach you have taken for SCPI + ACPI. Just forgot
to mention SCPI is old and deprecated protocol and SCMI replaced it. You
much be using that if possible.

Anyways, this kind of #ifdeffery is not allowed in any generic code even if
I agreed with the approach. So please don't change the code in such a way.

-- 
Regards,
Sudeep