linux-kernel - Re: nbd: please don't spawn 16 threads when nbd is not even in use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f07f496d-3bf7-eb84-eb90-df2d43c5c01b@huaweicloud.com>
Date:   Thu, 24 Nov 2022 19:17:05 +0800
From:   Yu Kuai <yukuai1@...weicloud.com>
To:     Pavel Machek <pavel@....cz>, Yu Kuai <yukuai1@...weicloud.com>
Cc:     Eric Blake <eblake@...hat.com>,
        kernel list <linux-kernel@...r.kernel.org>,
        josef@...icpanda.com, linux-block@...r.kernel.org,
        nbd@...er.debian.org, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: nbd: please don't spawn 16 threads when nbd is not even in use

Hi,

在 2022/11/24 18:06, Pavel Machek 写道:
> 
> Can we get that reverted?
> 
> That is rather obscure bug (how many GFP_KERNEL failures do you
> normally see?) and it costs, dunno, 100KB? of unswappable memory.
> 

No, I don't think that can be reverted. Introduce a BUG just to save
some memory sounds insane.

If you really want to do this. I think the right thing to do is to move
the allocation of recv_workq back to start device, and also fix the
problem properly.

Thanks,
Kuai
> Best regards,
> 								Pavel
>