linux-kernel - RE: [PATCH v2] cxgbi: cxgb4i: Added pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN9PR12MB5324F515DEBD4813246FCF8EBC0F9@BN9PR12MB5324.namprd12.prod.outlook.com>
Date:   Thu, 24 Nov 2022 11:19:37 +0000
From:   Varun Prakash <varun@...lsio.com>
To:     Mike Christie <michael.christie@...cle.com>,
        Denis Arefev <arefev@...mel.ru>
CC:     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lvc-project@...uxtesting.org" <lvc-project@...uxtesting.org>,
        "trufanov@...mel.ru" <trufanov@...mel.ru>,
        "vfh@...mel.ru" <vfh@...mel.ru>
Subject: RE: [PATCH v2] cxgbi: cxgb4i: Added pointer check


>> Return value of a function 'alloc_wr' is dereferenced at cxgb4i.c:624
>> without checking for null, but it is usually checked for this function
>> 
>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>> 
>> Signed-off-by: Denis Arefev <arefev@...mel.ru>
>> ---
>>  drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
>> index 2c3491528d42..b93bd36dcb2d 100644
>> --- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
>> +++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
>> @@ -620,6 +620,8 @@ static inline int send_tx_flowc_wr(struct cxgbi_sock *csk)
>>  #endif
>>  	flowclen16 = tx_flowc_wr_credits(&nparams, &flowclen);
>>  	skb = alloc_wr(flowclen, 0, GFP_ATOMIC);
>> +	if (!skb)
>> +		return -ENOMEM;
>
>If this returns a negative value push_tx_frames is going to mishandle it.
>I'm not sure how to best handle the failure there, but I cc'd the correct
>maintainer, Varun.

push_tx_frames() can not handle negative return value from send_tx_flowc_wr(),
to fix this issue we can preallocate a skb in alloc_cpls() and use this skb in send_tx_flowc_wr().