linux-kernel - RE: [Patch v5 2/3] media: s5p-mfc: Add variant data for MFC v7 hardware for Exynos 3250 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <001401d8fff9$eb9c53a0$c2d4fae0$@samsung.com>
Date:   Thu, 24 Nov 2022 17:13:02 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Aakarsh Jain'" <aakarsh.jain@...sung.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>
Cc:     <m.szyprowski@...sung.com>, <andrzej.hajda@...el.com>,
        <mchehab@...nel.org>, <hverkuil-cisco@...all.nl>,
        <ezequiel@...guardiasur.com.ar>, <jernej.skrabec@...il.com>,
        <benjamin.gaignard@...labora.com>,
        <krzysztof.kozlowski+dt@...aro.org>,
        <stanimir.varbanov@...aro.org>, <dillon.minfei@...il.com>,
        <david.plowman@...pberrypi.com>, <mark.rutland@....com>,
        <robh+dt@...nel.org>, <krzk+dt@...nel.org>, <andi@...zian.org>,
        <aswani.reddy@...sung.com>, <pankaj.dubey@...sung.com>,
        <smitha.t@...sung.com>
Subject: RE: [Patch v5 2/3] media: s5p-mfc: Add variant data for MFC v7
 hardware for Exynos 3250 SoC



>-----Original Message-----
>From: Aakarsh Jain [mailto:aakarsh.jain@...sung.com]
>Sent: Monday, November 14, 2022 5:20 PM
>To: linux-arm-kernel@...ts.infradead.org; linux-media@...r.kernel.org; linux-
>kernel@...r.kernel.org; devicetree@...r.kernel.org
>Cc: m.szyprowski@...sung.com; andrzej.hajda@...el.com;
>mchehab@...nel.org; hverkuil-cisco@...all.nl;
>ezequiel@...guardiasur.com.ar; jernej.skrabec@...il.com;
>benjamin.gaignard@...labora.com; krzysztof.kozlowski+dt@...aro.org;
>stanimir.varbanov@...aro.org; dillon.minfei@...il.com;
>david.plowman@...pberrypi.com; mark.rutland@....com;
>robh+dt@...nel.org; krzk+dt@...nel.org; andi@...zian.org;
>alim.akhtar@...sung.com; aswani.reddy@...sung.com;
>pankaj.dubey@...sung.com; smitha.t@...sung.com;
>aakarsh.jain@...sung.com
>Subject: [Patch v5 2/3] media: s5p-mfc: Add variant data for MFC v7 hardware
>for Exynos 3250 SoC
>
>Commit 5441e9dafdfc6dc40 ("[media] s5p-mfc: Core support for MFC v7")
>which adds mfc v7 support for Exynos3250 and use the same compatible string
>as used by Exynos5240 but both the IPs are a bit different in terms of IP clock.
>Add variant driver data based on the new compatible string
>"samsung,exynos3250-mfc" for Exynos3250 SoC.
>
>Suggested-by: Alim Akhtar <alim.akhtar@...sung.com>
>Fixes: 5441e9dafdfc ("[media] s5p-mfc: Core support for MFC v7")
>Signed-off-by: Aakarsh Jain <aakarsh.jain@...sung.com>
>---
Thanks!

Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>

> .../media/platform/samsung/s5p-mfc/s5p_mfc.c    | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
>b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
>index fca5c6405eec..007c7dbee037 100644
>--- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
>+++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
>@@ -1576,8 +1576,18 @@ static struct s5p_mfc_variant mfc_drvdata_v7 = {
> 	.port_num	= MFC_NUM_PORTS_V7,
> 	.buf_size	= &buf_size_v7,
> 	.fw_name[0]     = "s5p-mfc-v7.fw",
>-	.clk_names	= {"mfc", "sclk_mfc"},
>-	.num_clocks	= 2,
>+	.clk_names	= {"mfc"},
>+	.num_clocks	= 1,
>+};
>+
>+static struct s5p_mfc_variant mfc_drvdata_v7_3250 = {
>+	.version        = MFC_VERSION_V7,
>+	.version_bit    = MFC_V7_BIT,
>+	.port_num       = MFC_NUM_PORTS_V7,
>+	.buf_size       = &buf_size_v7,
>+	.fw_name[0]     = "s5p-mfc-v7.fw",
>+	.clk_names      = {"mfc", "sclk_mfc"},
>+	.num_clocks     = 2,
> };
>
> static struct s5p_mfc_buf_size_v6 mfc_buf_size_v8 = { @@ -1647,6 +1657,9
>@@ static const struct of_device_id exynos_mfc_match[] = {
> 	}, {
> 		.compatible = "samsung,mfc-v7",
> 		.data = &mfc_drvdata_v7,
>+	}, {
>+		.compatible = "samsung,exynos3250-mfc",
>+		.data = &mfc_drvdata_v7_3250,
> 	}, {
> 		.compatible = "samsung,mfc-v8",
> 		.data = &mfc_drvdata_v8,
>--
>2.17.1