linux-kernel - Re: [PATCH 09/11] blk-throttle: remove unnecessary check for validation of limit index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95ff6d32-7f4e-8ae3-8c95-4ce8ff111330@huawei.com>
Date:   Thu, 24 Nov 2022 20:58:50 +0800
From:   Kemeng Shi <shikemeng@...wei.com>
To:     Tejun Heo <tj@...nel.org>
CC:     <josef@...icpanda.com>, <axboe@...nel.dk>,
        <cgroups@...r.kernel.org>, <linux-block@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 09/11] blk-throttle: remove unnecessary check for
 validation of limit index



on 11/24/2022 2:31 AM, Tejun Heo wrote:
> On Wed, Nov 23, 2022 at 02:03:59PM +0800, Kemeng Shi wrote:
>> We always keep limit index valid as following:
>> Max limit is always valid and low limit can only be invalidated in
>> blk_throtl_update_limit_valid. Each time low limit may become invalid
>> after blk_throtl_update_limit_valid is called, we will check and make
>> sure current limit index is valid.
>>
>> It's reasonable to always keep limit index valid, so we can remove this
>> check.
> 
> It's not obvious to me that it's correct and I'm not sure what we're gaining
> by removing this while risking subtle breakages.
I will remove this patch in next version.

-- 
Best wishes
Kemeng Shi