linux-kernel - Re: [PATCH v2 0/5] exfat: move exfat_entry_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45e7ecdd-c4a0-5d41-5e32-db53424558da@samsung.com>
Date:   Thu, 24 Nov 2022 22:01:27 +0900
From:   Sungjong Seo <sjdev.seo@...il.com>
To:     "Yuezhang.Mo@...y.com" <Yuezhang.Mo@...y.com>,
        "linkinjeon@...nel.org" <linkinjeon@...nel.org>
Cc:     "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Andy.Wu@...y.com" <Andy.Wu@...y.com>,
        "Wataru.Aoyama@...y.com" <Wataru.Aoyama@...y.com>
Subject: Re: [PATCH v2 0/5] exfat: move exfat_entry_set_cache from heap to
 stack

Looks good.
Thanks for your patchset.

Reviewed-by: Sungjong Seo <sj1557.seo@...sung.com>

> This patchset reduces the size of exfat_entry_set_cache and moves
> it from heap to stack.
> 
> Changes for v2:
>   * [1/5] [5/5]
>     - Rename ES_*_ENTRY to ES_IDX_*
>     - Fix ES_IDX_LAST_FILENAME() to return the index of the last
>       filename entry
>     - Add ES_ENTRY_NUM() MACRO
> 
> Yuezhang Mo (5):
>   exfat: reduce the size of exfat_entry_set_cache
>   exfat: support dynamic allocate bh for exfat_entry_set_cache
>   exfat: move exfat_entry_set_cache from heap to stack
>   exfat: rename exfat_free_dentry_set() to exfat_put_dentry_set()
>   exfat: replace magic numbers with Macros
> 
>  fs/exfat/dir.c      | 70 ++++++++++++++++++++++++++-------------------
>  fs/exfat/exfat_fs.h | 37 ++++++++++++++++++------
>  fs/exfat/inode.c    | 13 ++++-----
>  fs/exfat/namei.c    | 11 ++++---
>  4 files changed, 80 insertions(+), 51 deletions(-)