linux-kernel - Re: [PATCH v1 1/1] pinctrl: intel: Save and restore pins in "direct IRQ" mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4BcguSaNlh7VbLQ@black.fi.intel.com>
Date:   Fri, 25 Nov 2022 08:11:14 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andy Shevchenko <andy@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        stable@...r.kernel.org, Dale Smith <dalepsmith@...il.com>,
        John Harris <jmharris@...il.com>
Subject: Re: [PATCH v1 1/1] pinctrl: intel: Save and restore pins in "direct
 IRQ" mode

On Fri, Nov 25, 2022 at 12:29:26AM +0200, Andy Shevchenko wrote:
> The firmware on some systems may configure GPIO pins to be
> an interrupt source in so called "direct IRQ" mode. In such
> cases the GPIO controller driver has no idea if those pins
> are being used or not. At the same time, there is a known bug
> in the firmwares that don't restore the pin settings correctly
> after suspend, i.e. by an unknown reason the Rx value becomes
> inverted.
> 
> Hence, let's save and restore the pins that are configured
> as GPIOs in the input mode with GPIROUTIOXAPIC bit set.
> 
> Cc: stable@...r.kernel.org
> Reported-and-tested-by: Dale Smith <dalepsmith@...il.com>
> Reported-and-tested-by: John Harris <jmharris@...il.com>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=214749
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Thanks Andy!

Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>