linux-kernel - Re: [PATCH bpf-next v2 1/3] bpf: Sanitize STX/ST in jited BPF progs with KASAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202211251510.fzpW7QEi-lkp@intel.com>
Date:   Fri, 25 Nov 2022 15:40:50 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hao Sun <sunhao.th@...il.com>, bpf@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, ast@...nel.org,
        daniel@...earbox.net, john.fastabend@...il.com, andrii@...nel.org,
        martin.lau@...ux.dev, song@...nel.org, yhs@...com,
        kpsingh@...nel.org, sdf@...gle.com, haoluo@...gle.com,
        jolsa@...nel.org, davem@...emloft.net,
        linux-kernel@...r.kernel.org, Hao Sun <sunhao.th@...il.com>
Subject: Re: [PATCH bpf-next v2 1/3] bpf: Sanitize STX/ST in jited BPF progs
 with KASAN

Hi Hao,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 2b3e8f6f5b939ceeb2e097339bf78ebaaf11dfe9]

url:    https://github.com/intel-lab-lkp/linux/commits/Hao-Sun/bpf-Add-LDX-STX-ST-sanitize-in-jited-BPF-progs/20221125-143743
base:   2b3e8f6f5b939ceeb2e097339bf78ebaaf11dfe9
patch link:    https://lore.kernel.org/r/20221125063630.536657-2-sunhao.th%40gmail.com
patch subject: [PATCH bpf-next v2 1/3] bpf: Sanitize STX/ST in jited BPF progs with KASAN
config: powerpc-allyesconfig
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b2fda8cc7c95aa1b69e2d247f3a18c7424ac15a9
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Hao-Sun/bpf-Add-LDX-STX-ST-sanitize-in-jited-BPF-progs/20221125-143743
        git checkout b2fda8cc7c95aa1b69e2d247f3a18c7424ac15a9
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash kernel/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> kernel/bpf/verifier.c:15335:21: warning: no previous prototype for 'bpf_asan_store8' [-Wmissing-prototypes]
   15335 |         notrace u64 bpf_asan_store##n(u##n *addr) \
         |                     ^~~~~~~~~~~~~~
   kernel/bpf/verifier.c:15342:1: note: in expansion of macro 'BPF_ASAN_STORE'
   15342 | BPF_ASAN_STORE(8);
         | ^~~~~~~~~~~~~~
>> kernel/bpf/verifier.c:15335:21: warning: no previous prototype for 'bpf_asan_store16' [-Wmissing-prototypes]
   15335 |         notrace u64 bpf_asan_store##n(u##n *addr) \
         |                     ^~~~~~~~~~~~~~
   kernel/bpf/verifier.c:15343:1: note: in expansion of macro 'BPF_ASAN_STORE'
   15343 | BPF_ASAN_STORE(16);
         | ^~~~~~~~~~~~~~
>> kernel/bpf/verifier.c:15335:21: warning: no previous prototype for 'bpf_asan_store32' [-Wmissing-prototypes]
   15335 |         notrace u64 bpf_asan_store##n(u##n *addr) \
         |                     ^~~~~~~~~~~~~~
   kernel/bpf/verifier.c:15344:1: note: in expansion of macro 'BPF_ASAN_STORE'
   15344 | BPF_ASAN_STORE(32);
         | ^~~~~~~~~~~~~~
>> kernel/bpf/verifier.c:15335:21: warning: no previous prototype for 'bpf_asan_store64' [-Wmissing-prototypes]
   15335 |         notrace u64 bpf_asan_store##n(u##n *addr) \
         |                     ^~~~~~~~~~~~~~
   kernel/bpf/verifier.c:15345:1: note: in expansion of macro 'BPF_ASAN_STORE'
   15345 | BPF_ASAN_STORE(64);
         | ^~~~~~~~~~~~~~


vim +/bpf_asan_store8 +15335 kernel/bpf/verifier.c

 15333	
 15334	#define BPF_ASAN_STORE(n)                         \
 15335		notrace u64 bpf_asan_store##n(u##n *addr) \
 15336		{                                         \
 15337			u##n ret = *addr;                 \
 15338			*addr = ret;                      \
 15339			return ret;                       \
 15340		}
 15341	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (329892 bytes)