linux-kernel - Re: [External] [PATCH] erofs: check the uniqueness of fsid in shared domain in advance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Nov 2022 16:55:17 +0800
From:   Gao Xiang <hsiangkao@...ux.alibaba.com>
To:     Hou Tao <houtao@...weicloud.com>
Cc:     Jia Zhu <zhujia.zj@...edance.com>, linux-erofs@...ts.ozlabs.org,
        Gao Xiang <xiang@...nel.org>, Chao Yu <chao@...nel.org>,
        Yue Hu <huyue2@...lpad.com>,
        Jeffle Xu <jefflexu@...ux.alibaba.com>, houtao1@...wei.com,
        linux-kernel@...r.kernel.org
Subject: Re: [External] [PATCH] erofs: check the uniqueness of fsid in shared
 domain in advance


Hi Tao,

On Fri, Nov 25, 2022 at 04:39:47PM +0800, Hou Tao wrote:
> Hi,
> 
> On 11/25/2022 4:25 PM, Jia Zhu wrote:
> > Hi Tao,
> > We've noticed this warning during development. It seems not a bug, so
> > I ignored that.
> > Many thanks for cacthing and clearing up the annoying warning.
> Yes, it is not a bug. The duplicated mount will fail with -EEXIST even without
> the patch. But it is a bit scary to see such warning in dmesg, so just fix it.

Thanks for the catch.

IMO, a WARN is indeed a bug, we cannot rely on this.

Overall the patch itself looks good to me as well, please help Cc LKML
mailing list as well in v2...

Thanks,
Gao Xiang