linux-kernel - Re: [PATCH] ARM: dts: lan966x: Add otp support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bdce1cb7-a771-4ec6-c75b-f547d26f95b3@microchip.com>
Date:   Fri, 25 Nov 2022 09:23:42 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <Horatiu.Vultur@...rochip.com>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <Nicolas.Ferre@...rochip.com>, <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH] ARM: dts: lan966x: Add otp support

Hi, Horatiu,

On 16.09.2022 22:49, Horatiu Vultur wrote:
> Add OTP (one time programmable) support.
> The both lan966x SocS (lan9662 and lan9668) have the same OTP IP.

If OTP IP is the same for both lan966x is there a reason you've added
compatibles for each SoC variants?

Thank you,
Claudiu Beznea

> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
> ---
>  arch/arm/boot/dts/lan966x.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> index 23665a0429906..784caba369485 100644
> --- a/arch/arm/boot/dts/lan966x.dtsi
> +++ b/arch/arm/boot/dts/lan966x.dtsi
> @@ -163,6 +163,11 @@ port7: port@7 {
>  			};
>  		};
>  
> +		otp: otp@...21000 {
> +			compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc";
> +			reg = <0xe0021000 0x300>;
> +		};
> +
>  		flx0: flexcom@...40000 {
>  			compatible = "atmel,sama5d2-flexcom";
>  			reg = <0xe0040000 0x100>;