linux-kernel - Re: [PATCH] ocfs2: properly clean task pointer before o2hb thread exits abnormally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <03a60f60-6408-b67c-6e66-d4ff1d24089c@linux.alibaba.com>
Date:   Fri, 25 Nov 2022 17:28:56 +0800
From:   Joseph Qi <joseph.qi@...ux.alibaba.com>
To:     lihongweizz <lihongweizz@...pur.com>, mark@...heh.com,
        jlbec@...lplan.org
Cc:     ocfs2-devel@....oracle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ocfs2: properly clean task pointer before o2hb thread
 exits abnormally



On 11/25/22 11:15 AM, lihongweizz wrote:
> From: Rock Li <lihongweizz@...pur.com>
> 
> in case o2hb thread exits abnormally before stop o2cb service,
> heartbeat_drop_group_item will try to stop a noexit thread cause
> ret->hb_task was not clear properly.
> 
Could you please describe the scenario in detail?

Thanks,
Joseph 

> Signed-off-by: Rock Li <lihongweizz@...pur.com>
> ---
>  fs/ocfs2/cluster/heartbeat.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c
> index b13d344..9db448d 100644
> --- a/fs/ocfs2/cluster/heartbeat.c
> +++ b/fs/ocfs2/cluster/heartbeat.c
> @@ -1258,6 +1258,8 @@ static int o2hb_thread(void *data)
>  	/* Unpin node */
>  	o2nm_undepend_this_node();
>  
> +	reg->hr_task = NULL;
> +
>  	mlog(ML_HEARTBEAT|ML_KTHREAD, "o2hb thread exiting\n");
>  
>  	return 0;