linux-kernel - Re: [PATCH] pinctrl: pinconf-generic: add missing of_node_put() in pinconf_generic_dt_node_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZ3XdKy2EXOTA-NdAvYa+7DOBB8rH66r4FExjjFPZqTuQ@mail.gmail.com>
Date:   Fri, 25 Nov 2022 10:49:56 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Peng Zhang <zhangpeng362@...wei.com>
Cc:     baruch@...s.co.il, ldewangan@...dia.com,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        sunnanyong@...wei.com, wangkefeng.wang@...wei.com
Subject: Re: [PATCH] pinctrl: pinconf-generic: add missing of_node_put() in pinconf_generic_dt_node_to_map()

On Fri, Nov 25, 2022 at 8:02 AM Peng Zhang <zhangpeng362@...wei.com> wrote:

> From: ZhangPeng <zhangpeng362@...wei.com>
>
> of_node_put() needs to be called when jumping out of the loop, since
> for_each_available_child_of_node() will increase the refcount of node.
>
> Fixes: c7289500e29d ("pinctrl: pinconf-generic: scan also referenced phandle node")
> Signed-off-by: ZhangPeng <zhangpeng362@...wei.com>

Good catch!
Patch applied.

Yours,
Linus Walleij