[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y4CR8/CXMhlMt+WS@paasikivi.fi.intel.com>
Date: Fri, 25 Nov 2022 09:59:15 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Yang Yingliang <yangyingliang@...wei.com>
Cc: linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
andriy.shevchenko@...ux.intel.com, djrscally@...il.com,
heikki.krogerus@...ux.intel.com, gregkh@...uxfoundation.org,
rafael@...nel.org
Subject: Re: [PATCH v3] device property: fix of node refcount leak in
fwnode_graph_get_next_endpoint()
Hi Yang,
Thank you for the patch.
On Wed, Nov 23, 2022 at 10:25:42AM +0800, Yang Yingliang wrote:
> The 'parent' returned by fwnode_graph_get_port_parent()
> with refcount incremented when 'prev' is not NULL, it
> needs be put when finish using it.
>
> Because the parent is const, introduce a new variable to
> store the returned fwnode, then put it before returning
> from fwnode_graph_get_next_endpoint().
>
> Fixes: b5b41ab6b0c1 ("device property: Check fwnode->secondary in fwnode_graph_get_next_endpoint()")
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
Reviewed-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
--
Sakari Ailus
Powered by blists - more mailing lists