linux-kernel - Re: [PATCH 5.10 000/149] 5.10.156-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <78fc17ac-bdce-4835-953d-d50d0a467146@app.fastmail.com>
Date:   Fri, 25 Nov 2022 11:32:49 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     YueHaibing <yuehaibing@...wei.com>,
        "Naresh Kamboju" <naresh.kamboju@...aro.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc:     stable@...r.kernel.org, patches@...ts.linux.dev,
        linux-kernel@...r.kernel.org,
        "Linus Torvalds" <torvalds@...ux-foundation.org>,
        "Andrew Morton" <akpm@...ux-foundation.org>,
        "Guenter Roeck" <linux@...ck-us.net>, shuah@...nel.org,
        patches@...nelci.org, lkft-triage@...ts.linaro.org,
        "Pavel Machek" <pavel@...x.de>,
        "Jon Hunter" <jonathanh@...dia.com>,
        "Florian Fainelli" <f.fainelli@...il.com>,
        "Sudip Mukherjee" <sudipm.mukherjee@...il.com>,
        srw@...dewatkins.net, rwarsow@....de,
        Netdev <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Paolo Abeni" <pabeni@...hat.com>,
        Daniel Díaz <daniel.diaz@...aro.org>
Subject: Re: [PATCH 5.10 000/149] 5.10.156-rc1 review

On Fri, Nov 25, 2022, at 11:25, YueHaibing wrote:
> On 2022/11/25 18:02, Arnd Bergmann wrote:
>> On Fri, Nov 25, 2022, at 09:05, Naresh Kamboju wrote:
>>> On Fri, 25 Nov 2022 at 12:57, Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
>>>> On Thu, Nov 24, 2022 at 09:17:36PM +0530, Naresh Kamboju wrote:
>>>>>
>>>>> Daniel bisected this reported problem and found the first bad commit,
>>>>>
>>>>> YueHaibing <yuehaibing@...wei.com>
>>>>>     net: broadcom: Fix BCMGENET Kconfig
>>>>
>>>> But that is in 5.10.155, 5.15.79, 6.0.9, and 6.1-rc5.  It is not new to
>>>> this -rc release.
>>>
>>> It started from 5.10.155 and this is only seen on 5.10 and other
>>> branches 5.15, 6.0 and mainline are looking good.
>> 
>> I think the original patch is wrong and should be fixed upstream.
>> The backported patch in question is a one-line Kconfig change doing
>
> It seems lts 5.10 do not contain commit e5f31552674e ("ethernet: fix 
> PTP_1588_CLOCK dependencies"),
> there is not PTP_1588_CLOCK_OPTIONAL option.

Ok, so there is a second problem then.

Greg, please just revert fbb4e8e6dc7b ("net: broadcom: Fix BCMGENET Kconfig")
in stable/linux-5.10.y: it depends on e5f31552674e ("ethernet: fix
PTP_1588_CLOCK dependencies"), which we probably don't want backported
from 5.15 to 5.10.

YueHaibing, do you agree with my suggestion for improving the
upstream 8d820bc9d12b ("net: broadcom: Fix BCMGENET Kconfig")
commit? Can you send a follow-up fix, or should I?

      Arnd