linux-kernel - Re: [PATCH 1/3] arm64: arch_k3: Removed ti mailbox and sci select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Nov 2022 11:36:14 +0100
From:   Nicolas Frayer <nfrayer@...libre.com>
To:     Vignesh Raghavendra <vigneshr@...com>
Cc:     nm@...com, kristo@...nel.org, ssantosh@...nel.org,
        linux-arm-kernel@...ts.infradead.org, jassisinghbrar@...il.com,
        catalin.marinas@....com, will@...nel.org,
        linux-kernel@...r.kernel.org, khilman@...libre.com,
        glaroque@...libre.com
Subject: Re: [PATCH 1/3] arm64: arch_k3: Removed ti mailbox and sci select

Le jeu. 24 nov. 2022 à 15:29, Vignesh Raghavendra <vigneshr@...com> a écrit :
>
>
>
> On 23/11/22 1:52 am, Nicolas Frayer wrote:
> > In order to build ti mailbox and ti sci as modules,
> > remove their automatic selection by ARCH_K3
> >
>
> $Subject: s/Removed/Remove,
> s/ti/TI
> s/sci/SCI
>
> > Signed-off-by: Nicolas Frayer <nfrayer@...libre.com>
> > ---
> >  arch/arm64/Kconfig.platforms | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> > index 912529ac58b3..5f16eb498dbf 100644
> > --- a/arch/arm64/Kconfig.platforms
> > +++ b/arch/arm64/Kconfig.platforms
> > @@ -126,8 +126,6 @@ config ARCH_K3
> >       select PM_GENERIC_DOMAINS if PM
> >       select MAILBOX
> >       select SOC_TI
> > -     select TI_MESSAGE_MANAGER
> > -     select TI_SCI_PROTOCOL
> >       select TI_SCI_INTR_IRQCHIP
> >       select TI_SCI_INTA_IRQCHIP
> >       help
>
>
> Why not use "imply" instead of "select". This should allow TI_SCI*
> drivers to be built as modules if required. Would make 2/3 and 3/3
> redundant.
>
> Also, note that 1/3, 2/3 and 3/3 have to go through 3 different trees,
> so not a great idea to post as a single series.
>
> Regards
> Vignesh

Thanks Vignesh, I'll send a v2 using imply and drop 2/3 and 3/3