[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y4CcspD1xkmhmWbh@smile.fi.intel.com>
Date: Fri, 25 Nov 2022 12:45:06 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Gerald Loacker <gerald.loacker@...fvision.net>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Jonathan Cameron <jic23@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Jakob Hauser <jahau@...ketmail.com>,
Linus Walleij <linus.walleij@...aro.org>,
Nikita Yushchenko <nikita.yoush@...entembedded.com>,
Michael Riesch <michael.riesch@...fvision.net>
Subject: Re: [PATCH v3 1/3] iio: add struct declarations for iio types
On Fri, Nov 25, 2022 at 09:35:24AM +0100, Gerald Loacker wrote:
> Add structs for iio type arrays such as IIO_AVAIL_LIST which can be used
> instead of int arrays.
Suggested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
And thank you for doing this!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
(one comment below)
> Signed-off-by: Gerald Loacker <gerald.loacker@...fvision.net>
> ---
> include/linux/iio/iio.h | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index f0ec8a5e5a7a..eaf6727445a6 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -383,6 +383,21 @@ s64 iio_get_time_ns(const struct iio_dev *indio_dev);
>
> struct iio_trigger; /* forward declaration */
>
> +struct iio_val_int_plus_micro {
> + int val_int;
> + int val_micro;
> +};
> +
> +struct iio_val_int_plus_nano {
> + int val_int;
> + int val_nano;
> +};
> +
> +struct iio_val_int_plus_micro_db {
> + int val_int;
int val_int_db; ?
> + int val_micro_db;
> +};
Actually why can't we simply do
typedef iio_val_int_plus_micro_db iio_val_int_plus_micro;
?
> /**
> * struct iio_info - constant information about device
> * @event_attrs: event control attributes
> --
> 2.37.2
>
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists