linux-kernel - Re: [PATCH] ARM: dts: lan966x: Add otp support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9302133d-e217-e44e-5372-7bd05865f36a@microchip.com>
Date:   Fri, 25 Nov 2022 11:10:22 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <Horatiu.Vultur@...rochip.com>
CC:     <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <Nicolas.Ferre@...rochip.com>, <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH] ARM: dts: lan966x: Add otp support

On 25.11.2022 12:01, Horatiu Vultur - M31836 wrote:
> The 11/25/2022 09:23, Claudiu Beznea - M18063 wrote:
>> Hi, Horatiu,
> 
> Hi Claudiu,
> 
>>
>> On 16.09.2022 22:49, Horatiu Vultur wrote:
>>> Add OTP (one time programmable) support.
>>> The both lan966x SocS (lan9662 and lan9668) have the same OTP IP.
>>
>> If OTP IP is the same for both lan966x is there a reason you've added
>> compatibles for each SoC variants?
> 
> When I was adding the device tree binding, Krzystof mention not to have
> any wilcards in compatible string [0].

I was thinking at having only one of microchip,lan9668-otpc or
microchip,lan9662-otpc whoever was first.

> 
> [0] https://lore.kernel.org/lkml/550e652e-4541-c1e6-33a7-d5555f0cb266@linaro.org/
> 
>>
>> Thank you,
>> Claudiu Beznea
>>
>>>
>>> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
>>> ---
>>>  arch/arm/boot/dts/lan966x.dtsi | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
>>> index 23665a0429906..784caba369485 100644
>>> --- a/arch/arm/boot/dts/lan966x.dtsi
>>> +++ b/arch/arm/boot/dts/lan966x.dtsi
>>> @@ -163,6 +163,11 @@ port7: port@7 {
>>>  			};
>>>  		};
>>>  
>>> +		otp: otp@...21000 {
>>> +			compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc";
>>> +			reg = <0xe0021000 0x300>;
>>> +		};
>>> +
>>>  		flx0: flexcom@...40000 {
>>>  			compatible = "atmel,sama5d2-flexcom";
>>>  			reg = <0xe0040000 0x100>;
>>
>