linux-kernel - Re: [PATCH] ARM: dts: at91: sama7g5ek: align power rails for sdmmc0/1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c638ac2-3855-04ec-1f83-43b81b5aeb22@microchip.com>
Date:   Fri, 25 Nov 2022 11:35:01 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <Eugen.Hristev@...rochip.com>, <robh+dt@...nel.org>
CC:     <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: at91: sama7g5ek: align power rails for sdmmc0/1

On 24.11.2022 17:46, Eugen Hristev wrote:
> On this board SDMMC0 has a 1.8 signaled eMMC device powered at
> 3.3 V .
> Hence, correctly describe the connected rails from the PMIC.
> 
> SDMMC1 is connected to a voltage switch that can change from
> 3.3V to 1.8V by a hardware controlled pin.
> However SDMMC1 at the moment works only 3.3V mode (default speed,
> no UHS-I modes), thus connect the signaling to the 3.3V rail.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@...rochip.com>

Applied to at91-dt (after reshaped a bit the commit message), thanks!

> ---
>  arch/arm/boot/dts/at91-sama7g5ek.dts | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama7g5ek.dts b/arch/arm/boot/dts/at91-sama7g5ek.dts
> index 3b25c67795dd..aa5cc0e98bba 100644
> --- a/arch/arm/boot/dts/at91-sama7g5ek.dts
> +++ b/arch/arm/boot/dts/at91-sama7g5ek.dts
> @@ -764,8 +764,9 @@ &rtt {
>  &sdmmc0 {
>  	bus-width = <8>;
>  	non-removable;
> -	no-1-8-v;
>  	sdhci-caps-mask = <0x0 0x00200000>;
> +	vmmc-supply = <&vdd_3v3>;
> +	vqmmc-supply = <&vldo1>;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_sdmmc0_default>;
>  	status = "okay";
> @@ -775,6 +776,8 @@ &sdmmc1 {
>  	bus-width = <4>;
>  	no-1-8-v;
>  	sdhci-caps-mask = <0x0 0x00200000>;
> +	vmmc-supply = <&vdd_3v3>;
> +	vqmmc-supply = <&vdd_3v3>;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_sdmmc1_default>;
>  	status = "okay";