linux-kernel - Re: [PATCH v2 1/2] dt-bindings: mfd: syscon: Add tesla compatibles found on FSD SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Nov 2022 12:39:58 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Sriranjani P <sriranjani.p@...sung.com>, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, lee@...nel.org,
        devicetree@...r.kernel.org, alim.akhtar@...sung.com,
        pankaj.dubey@...sung.com, ravi.patel@...sung.com,
        Sam Protsenko <semen.protsenko@...aro.org>,
        Chanho Park <chanho61.park@...sung.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: mfd: syscon: Add tesla compatibles
 found on FSD SoC

On 25/11/2022 12:29, Krzysztof Kozlowski wrote:
> On 25/11/2022 08:06, Sriranjani P wrote:
>> Add compatible for Tesla SYSREG controllers found on FSD SoC.
>>
>> Signed-off-by: Sriranjani P <sriranjani.p@...sung.com>
>> ---
> 
> Thank you for your patch. There is something to discuss/improve.
> 
>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
>> index 4e4baf53796d..8c3334999bec 100644
>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>> @@ -69,6 +69,7 @@ properties:
>>                - samsung,exynos5433-sysreg
>>                - samsung,exynos850-sysreg
>>                - samsung,exynosautov9-sysreg
>> +              - tesla,fsd-sysreg
> 
> I think we made mistake starting from 5433. Before (Exynos3/4/5) there
> was only one block called actually SYSREG. For example on Exynos5433 we
> have SYSREG_DISP, SYSREG_CAM1 and so on. These are different so we
> should have dedicated compatibles. The same for Tesla - please provide
> dedicated compatibles per each block.
> 
> I'll fix Exynos5433. Maybe someone can also fix Exynos850 and Autov9.

To clarify - in case of Tesla, you do not need the fallbacks, so you
just add few of:
   - tesla,fsd-xxx-sysreg
within the enum.

For Exynos850 and Autov9, just like for Exynso5433, we should keep it
backwards compatible, so we need fallbacks.

Best regards,
Krzysztof