linux-kernel - Re: [PATCH] fs: namei: fix two excess parameter description warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49d0555b-7bd3-f8c7-f9ff-683d9720c6c7@infradead.org>
Date:   Thu, 24 Nov 2022 18:51:48 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Kushagra Verma <kushagra765@...look.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: namei: fix two excess parameter description warnings



On 11/17/22 04:28, Kushagra Verma wrote:
> While building the kernel documentation, two excess parameter description
> warnings appear:
> 	./fs/namei.c:3589: warning: Excess function parameter 'dentry'
> 	description in 'vfs_tmpfile'
> 	./fs/namei.c:3589: warning: Excess function parameter 'open_flag'
> 	description in 'vfs_tmpfile'
> 
> Fix these warnings by changing 'dentry' to 'parentpath' in the parameter
> description and 'open_flag' to 'file' and change 'file' parameter's
> description accordingly.
> 
> Signed-off-by: Kushagra Verma <kushagra765@...look.com>

Tested-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  fs/namei.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/namei.c b/fs/namei.c
> index 578c2110df02..8e77e194fed5 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -3571,9 +3571,9 @@ static int do_open(struct nameidata *nd,
>  /**
>   * vfs_tmpfile - create tmpfile
>   * @mnt_userns:	user namespace of the mount the inode was found from
> - * @dentry:	pointer to dentry of the base directory
> + * @parentpath:	pointer to dentry of the base directory
>   * @mode:	mode of the new tmpfile
> - * @open_flag:	flags
> + * @file:	file information
>   *
>   * Create a temporary file.
>   *

-- 
~Randy