[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <a714a297-fa5f-4238-c6ad-bc22cbc1d14c@linaro.org>
Date: Fri, 25 Nov 2022 14:00:17 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Tomeu Vizoso <tomeu.vizoso@...labora.com>
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Kevin Hilman <khilman@...libre.com>,
Jerome Brunet <jbrunet@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
"moderated list:ARM/Amlogic Meson SoC support"
<linux-arm-kernel@...ts.infradead.org>,
"open list:ARM/Amlogic Meson SoC support"
<linux-amlogic@...ts.infradead.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/6] arm64: dts: meson-g12-common: Add reference to NNA
reset to pwrc
On 25/11/2022 12:19, Tomeu Vizoso wrote:
> Based on the power sequence in the downstream driver.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@...labora.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index 45947c1031c4..fa96fddf4633 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -1625,10 +1625,11 @@ pwrc: power-controller {
> <&reset RESET_VDAC>,
> <&reset RESET_VDI6>,
> <&reset RESET_VENCL>,
> - <&reset RESET_VID_LOCK>;
> + <&reset RESET_VID_LOCK>,
> + <&reset RESET_NNA>;
I think this should go in the npu node instead, those are for the VPU power domain.
> reset-names = "viu", "venc", "vcbus", "bt656",
> "rdma", "venci", "vencp", "vdac",
> - "vdi6", "vencl", "vid_lock";
> + "vdi6", "vencl", "vid_lock", "nna";
> clocks = <&clkc CLKID_VPU>,
> <&clkc CLKID_VAPB>;
> clock-names = "vpu", "vapb";
Powered by blists - more mailing lists