linux-kernel - Re: [PATCH] perf arm64: Fix mksyscalltbl, don't lose syscalls due to sort -nu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <98978f82-eb78-4fa7-901e-76c3070362e3@app.fastmail.com>
Date:   Fri, 25 Nov 2022 14:56:31 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Leo Yan" <leo.yan@...aro.org>,
        "Vincent Whitchurch" <vincent.whitchurch@...s.com>
Cc:     "Arnaldo Carvalho de Melo" <acme@...nel.org>,
        "Hans-Peter Nilsson" <hp@...s.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        "John Garry" <john.garry@...wei.com>,
        "Will Deacon" <will@...nel.org>,
        "Mathieu Poirier" <mathieu.poirier@...aro.org>,
        "Peter Zijlstra" <peterz@...radead.org>,
        "Ingo Molnar" <mingo@...hat.com>,
        "Mark Rutland" <mark.rutland@....com>,
        "Alexander Shishkin" <alexander.shishkin@...ux.intel.com>,
        "Jiri Olsa" <jolsa@...hat.com>,
        "Namhyung Kim" <namhyung@...nel.org>,
        "Kim Phillips" <kim.phillips@....com>
Subject: Re: [PATCH] perf arm64: Fix mksyscalltbl, don't lose syscalls due to sort -nu

On Fri, Nov 25, 2022, at 13:54, Leo Yan wrote:
> On Fri, Nov 25, 2022 at 12:53:10PM +0100, Vincent Whitchurch wrote:

>> It looks like this patch was never applied?  AFAICS it is still needed
>> on current HEAD and it still applies cleanly.
>
> Thanks a lot for bringing up this.
>
> Before there have a discussion [1] for refactoring Arm64 system call
> table but it didn't really happen.

I actually worked on this last week and did a new series to convert
the old asm-generic/unistd.h header into the syscall.tbl format,
and change arm64 to use that.

You can find my work in the 'syscall-tbl' branch of my asm-generic
tree [1]. This has only seen light build testing so far, and is
probably still buggy, but most of the work is there. The missing
bits are the Makefiles for the other seven architectures using
asm-generic/unistd.h, and checking the output to ensure the
contents are still the same.

> I think it's the right thing to merge
> this patch, @Arnaldo, could you pick up this patch?

That sounds fine to me.

    Arnd

[1] https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git/