linux-kernel - Re: [PATCH 2/2] ARM: dts: qcom: align LED node names with dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e44abbe6-080f-e0d5-5311-04e3a1e9f66e@linaro.org>
Date:   Fri, 25 Nov 2022 15:55:44 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: qcom: align LED node names with dtschema



On 25.11.2022 15:42, Krzysztof Kozlowski wrote:
> The node names should be generic and DT schema expects certain pattern:
> 
>   qcom-ipq4018-ap120c-ac.dtb: leds: 'wlan2g', 'wlan5g' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>  arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts | 6 +++---
>  arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts     | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts
> index cf7da1ab177c..1b27edce9d4f 100644
> --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts
> +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dts
> @@ -9,7 +9,7 @@ / {
>  	leds {
>  		compatible = "gpio-leds";
>  
> -		power {
> +		led-power {
>  			label = "ap120c-ac:green:power";
>  			function = LED_FUNCTION_POWER;
>  			color = <LED_COLOR_ID_GREEN>;
> @@ -17,14 +17,14 @@ power {
>  			default-state = "on";
>  		};
>  
> -		wlan {
> +		led-wlan {
>  			label = "ap120c-ac:green:wlan";
>  			function = LED_FUNCTION_WLAN;
>  			color = <LED_COLOR_ID_GREEN>;
>  			gpios = <&tlmm 3 GPIO_ACTIVE_HIGH>;
>  		};
>  
> -		support {
> +		led-support {
>  			label = "ap120c-ac:green:support";
>  			color = <LED_COLOR_ID_GREEN>;
>  			gpios = <&tlmm 2 GPIO_ACTIVE_HIGH>;
> diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts
> index c4f89b712fd9..a707057c887d 100644
> --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts
> +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dts
> @@ -7,7 +7,7 @@ / {
>  	leds {
>  		compatible = "gpio-leds";
>  
> -		status: status {
> +		status: led-status {
>  			label = "ap120c-ac:blue:status";
>  			function = LED_FUNCTION_STATUS;
>  			color = <LED_COLOR_ID_BLUE>;
> @@ -15,7 +15,7 @@ status: status {
>  			default-state = "keep";
>  		};
>  
> -		wlan2g {
> +		led-wlan2g {
>  			label = "ap120c-ac:green:wlan2g";
>  			function = LED_FUNCTION_WLAN;
>  			color = <LED_COLOR_ID_GREEN>;
> @@ -23,7 +23,7 @@ wlan2g {
>  			linux,default-trigger = "phy0tpt";
>  		};
>  
> -		wlan5g {
> +		led-wlan5g {
>  			label = "ap120c-ac:red:wlan5g";
>  			function = LED_FUNCTION_WLAN;
>  			color = <LED_COLOR_ID_RED>;