lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Nov 2022 11:59:22 +0800 From: Jammy Huang <jammy_huang@...eedtech.com> To: Zev Weiss <zweiss@...inix.com> CC: "eajames@...ux.ibm.com" <eajames@...ux.ibm.com>, "mchehab@...nel.org" <mchehab@...nel.org>, "joel@....id.au" <joel@....id.au>, "andrew@...id.au" <andrew@...id.au>, "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>, "zev@...ilderbeest.net" <zev@...ilderbeest.net>, "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>, "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] media: aspeed: Use v4l2_dbg to replace v4l2_warn to avoid log spam Hi Zev, On 2022/11/23 上午 07:12, Zev Weiss wrote: > On Thu, Nov 10, 2022 at 01:56:11AM PST, Jammy Huang wrote: >> If the host is powered off, there will be many warning log. To avoid the >> log spam in this condition, replace v4l2_warn with v4l2_dbg. >> >> Signed-off-by: Jammy Huang <jammy_huang@...eedtech.com> >> --- >> drivers/media/platform/aspeed/aspeed-video.c | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >> > Thanks Jammy -- after dropping the one hunk that wasn't applicable (due > to not having all the prerequisite patches) this definitely fixed the > log noise problems I'd been having. > > I'm assuming the prerequisite patches are from your aspeed-jpeg support > patch series? If so, since this is a smaller/simpler patch, I think it > might make sense to reorder things to try to get this merged first and > then fixing up that patchset to use v4l2_dbg() instead of v4l2_warn(), > rather than introducing a new instance of it and then patching it back > out later with this one. Yes, the prerequisite patches are 'aspeed-jpeg support' patch series. And that patch series has been accepted and pull for v6.2. Your suggestion is better to decouple these patches. I would pay attention to the problem like this to avoid this condition in the future. Many thanks for your kindly help. > > > Thanks, > Zev -- Best Regards Jammy
Powered by blists - more mailing lists