lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <7293f7a2-0136-1c1c-e6ac-4fe810081c64@xs4all.nl> Date: Sat, 26 Nov 2022 11:14:08 +0100 From: Hans Verkuil <hverkuil@...all.nl> To: Luiz Sampaio <sampaio.ime@...il.com>, Mauro Carvalho Chehab <mchehab@...nel.org> Cc: linux-kernel@...r.kernel.org, linux-media@...r.kernel.org Subject: Re: [PATCH 12/31] media: v4l2-core: changing LED_* from enum led_brightness to actual value Hi Luiz, On 21/01/2022 17:54, Luiz Sampaio wrote: > The enum led_brightness, which contains the declaration of LED_OFF, > LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports > max_brightness. Note that there is no Signed-off-by line, so I can't take this. Same for patches 11/31 and 10/31. If this is still relevant (it's an old series, after all), then please repost. Regards, Hans > --- > drivers/media/v4l2-core/v4l2-flash-led-class.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/v4l2-core/v4l2-flash-led-class.c b/drivers/media/v4l2-core/v4l2-flash-led-class.c > index e70e128ccc9c..a47ac654c9f4 100644 > --- a/drivers/media/v4l2-core/v4l2-flash-led-class.c > +++ b/drivers/media/v4l2-core/v4l2-flash-led-class.c > @@ -234,11 +234,11 @@ static int v4l2_flash_s_ctrl(struct v4l2_ctrl *c) > case V4L2_CID_FLASH_LED_MODE: > switch (c->val) { > case V4L2_FLASH_LED_MODE_NONE: > - led_set_brightness_sync(led_cdev, LED_OFF); > + led_set_brightness_sync(led_cdev, 0); > return led_set_flash_strobe(fled_cdev, false); > case V4L2_FLASH_LED_MODE_FLASH: > /* Turn the torch LED off */ > - led_set_brightness_sync(led_cdev, LED_OFF); > + led_set_brightness_sync(led_cdev, 0); > if (ctrls[STROBE_SOURCE]) { > external_strobe = (ctrls[STROBE_SOURCE]->val == > V4L2_FLASH_STROBE_SOURCE_EXTERNAL);
Powered by blists - more mailing lists