lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAOPdzVbXQLov1z1e3eqJ+nodtuc6GMj8LhQOAGkZJNw8VZ9h3Q@mail.gmail.com> Date: Sat, 26 Nov 2022 16:28:22 +0530 From: shravan kumar <shravanmicrochip@...il.com> To: Sakari Ailus <sakari.ailus@....fi> Cc: shravan kumar <shravan.chippa@...rochip.com>, paul.j.murphy@...el.com, daniele.alessandrelli@...el.com, mchehab@...nel.org, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v5 4/6] media: i2c: imx334: add default values in 3840x2160@60 array On Fri, Nov 25, 2022 at 9:50 PM Sakari Ailus <sakari.ailus@....fi> wrote: > > Hi Shravan, > > On Fri, Nov 25, 2022 at 10:38:05AM +0530, shravan kumar wrote: > > From: Shravan Chippa <shravan.chippa@...rochip.com> > > > > -If we have only one mode there is no need to update camera > > reset(default) values when we initialize the camera > > How is this related to the patch? > > > > > -If we have mutipull modes in this case we need all value to > > write while camera initializing, so i will not effect other modes > > while shifting dynamically > > > > -All default values for 3840x2160@60 updated becouse if we change > > the mode we will not be able to recover the values, so add in > > mode_3840x2160_regs[] array > > Please remove dashes in front of the paragrahs and use period in the end of > sentences. > > Are these registers' values specific to this mode or are they different on > different modes? Yes, These are different for different mods default values are matching with 3840x2160@60 mode if we change mode dynamically we need to take care. so added. Thanks, Shravan > > > > > Signed-off-by: Shravan Chippa <shravan.chippa@...rochip.com> > > --- > > drivers/media/i2c/imx334.c | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c > > index d3bb62c162b3..cd41df56ab7d 100644 > > --- a/drivers/media/i2c/imx334.c > > +++ b/drivers/media/i2c/imx334.c > > @@ -166,6 +166,7 @@ static const struct imx334_reg mode_3840x2160_regs[] = { > > {0x3288, 0x21}, > > {0x328a, 0x02}, > > {0x302c, 0x3c}, > > + {0x302d, 0x00}, > > {0x302e, 0x00}, > > {0x302f, 0x0f}, > > {0x3076, 0x70}, > > @@ -240,7 +241,26 @@ static const struct imx334_reg mode_3840x2160_regs[] = { > > {0x3794, 0x7a}, > > {0x3796, 0xa1}, > > {0x3e04, 0x0e}, > > + {0x319e, 0x00}, > > {0x3a00, 0x01}, > > + {0x3A18, 0xBF}, > > + {0x3A19, 0x00}, > > + {0x3A1A, 0x67}, > > + {0x3A1B, 0x00}, > > + {0x3A1C, 0x6F}, > > + {0x3A1D, 0x00}, > > + {0x3A1E, 0xD7}, > > + {0x3A1F, 0x01}, > > + {0x3A20, 0x6F}, > > + {0x3A21, 0x00}, > > + {0x3A22, 0xCF}, > > + {0x3A23, 0x00}, > > + {0x3A24, 0x6F}, > > + {0x3A25, 0x00}, > > + {0x3A26, 0xB7}, > > + {0x3A27, 0x00}, > > + {0x3A28, 0x5F}, > > + {0x3A29, 0x00}, > > }; > > > > /* Supported sensor mode configurations */ > > -- > Kind regards, > > Sakari Ailus
Powered by blists - more mailing lists