lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20221126000401.25302-1-rdunlap@infradead.org> Date: Fri, 25 Nov 2022 16:04:01 -0800 From: Randy Dunlap <rdunlap@...radead.org> To: linux-kernel@...r.kernel.org Cc: Randy Dunlap <rdunlap@...radead.org>, Arnd Bergmann <arnd@...db.de>, Masahiro Yamada <masahiroy@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, Michal Suchánek <msuchanek@...e.de>, linuxppc-dev@...ts.ozlabs.org, Daniel Vetter <daniel@...ll.ch>, Helge Deller <deller@....de>, linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org Subject: [PATCH] fbdev: make offb driver tristate Make the offb (Open Firmware frame buffer) driver tristate, i.e., so that it can be built as a loadable module. However, it still depends on the setting of DRM_OFDRM so that both of these drivers cannot be builtin at the same time nor can one be builtin and the other one a loadable module. Build-tested successfully with all combination of DRM_OFDRM and FB_OF. This fixes a build issue that Michal reported when FB_OF=y and DRM_OFDRM=m: powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x58): undefined reference to `cfb_fillrect' powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x60): undefined reference to `cfb_copyarea' powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x68): undefined reference to `cfb_imageblit' Signed-off-by: Randy Dunlap <rdunlap@...radead.org> Suggested-by: Arnd Bergmann <arnd@...db.de> Cc: Masahiro Yamada <masahiroy@...nel.org> Cc: Thomas Zimmermann <tzimmermann@...e.de> Cc: Michal Suchánek <msuchanek@...e.de> Cc: linuxppc-dev@...ts.ozlabs.org Cc: Daniel Vetter <daniel@...ll.ch> Cc: Helge Deller <deller@....de> Cc: linux-fbdev@...r.kernel.org Cc: dri-devel@...ts.freedesktop.org --- drivers/video/fbdev/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -456,8 +456,8 @@ config FB_ATARI chipset found in Ataris. config FB_OF - bool "Open Firmware frame buffer device support" - depends on (FB = y) && PPC && (!PPC_PSERIES || PCI) + tristate "Open Firmware frame buffer device support" + depends on FB && PPC && (!PPC_PSERIES || PCI) depends on !DRM_OFDRM select APERTURE_HELPERS select FB_CFB_FILLRECT
Powered by blists - more mailing lists