lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <166946968386.4906.165635954561473495.tip-bot2@tip-bot2> Date: Sat, 26 Nov 2022 13:34:43 -0000 From: "irqchip-bot for Jianmin Lv" <tip-bot2@...utronix.de> To: linux-kernel@...r.kernel.org Cc: Jianmin Lv <lvjianmin@...ngson.cn>, Huacai Chen <chenhuacai@...ngson.cn>, Marc Zyngier <maz@...nel.org>, tglx@...utronix.de Subject: [irqchip: irq/irqchip-next] irqchip/loongson-pch-pic: Fix translate callback for DT path The following commit has been merged into the irq/irqchip-next branch of irqchip: Commit-ID: c7c00138015975c8f0e268564249cc47d8de632c Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/c7c00138015975c8f0e268564249cc47d8de632c Author: Jianmin Lv <lvjianmin@...ngson.cn> AuthorDate: Sat, 22 Oct 2022 15:59:53 +08:00 Committer: Marc Zyngier <maz@...nel.org> CommitterDate: Sat, 26 Nov 2022 13:05:38 irqchip/loongson-pch-pic: Fix translate callback for DT path In DT path of translate callback, if fwspec->param_count==1 and of_node is non-null, fwspec->param[1] will be accessed, which is introduced from previous commit bcdd75c596c8 (irqchip/loongson-pch-pic: Add ACPI init support). Before the patch, for non-null of_node, translate callback (use irq_domain_translate_twocell()) will return -EINVAL if fwspec->param_count < 2, so the check in the patch is added. Fixes: bcdd75c596c8 ("irqchip/loongson-pch-pic: Add ACPI init support") Signed-off-by: Jianmin Lv <lvjianmin@...ngson.cn> Reviewed-by: Huacai Chen <chenhuacai@...ngson.cn> Signed-off-by: Marc Zyngier <maz@...nel.org> Link: https://lore.kernel.org/r/20221022075955.11726-3-lvjianmin@loongson.cn --- drivers/irqchip/irq-loongson-pch-pic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/irqchip/irq-loongson-pch-pic.c b/drivers/irqchip/irq-loongson-pch-pic.c index c01b9c2..03493cd 100644 --- a/drivers/irqchip/irq-loongson-pch-pic.c +++ b/drivers/irqchip/irq-loongson-pch-pic.c @@ -159,6 +159,9 @@ static int pch_pic_domain_translate(struct irq_domain *d, return -EINVAL; if (of_node) { + if (fwspec->param_count < 2) + return -EINVAL; + *hwirq = fwspec->param[0] + priv->ht_vec_base; *type = fwspec->param[1] & IRQ_TYPE_SENSE_MASK; } else {
Powered by blists - more mailing lists