lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20221126142735.47dcca6d@slackpad.lan> Date: Sat, 26 Nov 2022 14:28:23 +0000 From: Andre Przywara <andre.przywara@....com> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> Cc: Samuel Holland <samuel@...lland.org>, Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>, "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, LABBE Corentin <clabbe.montjoie@...il.com>, Maxime Ripard <mripard@...nel.org>, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-sunxi@...ts.linux.dev, netdev@...r.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: net: sun8i-emac: Fix snps,dwmac.yaml inheritance On Sat, 26 Nov 2022 14:26:25 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote: Hi, > On 25/11/2022 21:20, Samuel Holland wrote: > > The sun8i-emac binding extends snps,dwmac.yaml, and should accept all > > properties defined there, including "mdio", "resets", and "reset-names". > > However, validation currently fails for these properties because the > > validation does not fail: > make dt_binding_check -> no problems > > Maybe you meant that DTS do not pass dtbs_check? Yes, that's what he meant: If a board actually doesn't have Ethernet configured, dt-validate complains. I saw this before, but didn't find any solution. An example is: $ dt-validate ... sun50i-a64-pinephone-1.2.dtb arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dtb: ethernet@...0000: Unevaluated properties are not allowed ('resets', 'reset-names', 'mdio' were unexpected) From schema: Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml Why exactly is beyond me, but this patch removes this message. Cheers, Andre > > local binding sets "unevaluatedProperties: false", and snps,dwmac.yaml > > is only included inside an allOf block. Fix this by referencing > > snps,dwmac.yaml at the top level. > > There is nothing being fixed here... > > > > > Signed-off-by: Samuel Holland <samuel@...lland.org> > > --- > > > > .../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml > > index 1432fda3b603..34a47922296d 100644 > > --- a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml > > +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml > > @@ -10,6 +10,8 @@ maintainers: > > - Chen-Yu Tsai <wens@...e.org> > > - Maxime Ripard <mripard@...nel.org> > > > > +$ref: "snps,dwmac.yaml#" > > + > > properties: > > compatible: > > oneOf: > > @@ -60,7 +62,6 @@ required: > > - syscon > > > > allOf: > > - - $ref: "snps,dwmac.yaml#" > > - if: > > properties: > > compatible: > > Best regards, > Krzysztof > >
Powered by blists - more mailing lists