linux-kernel - Re: [PATCH 2/3] powerpc/book3e: remove #include <generated/utsrelease.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d48f728c-18ac-727c-6e0f-8b30e955449e@csgroup.eu>
Date:   Sat, 26 Nov 2022 14:54:37 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Thomas Weißschuh <linux@...ssschuh.net>
CC:     Luis Chamberlain <mcgrof@...nel.org>,
        Russ Weight <russell.h.weight@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Nicholas Piggin <npiggin@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>
Subject: Re: [PATCH 2/3] powerpc/book3e: remove #include
 <generated/utsrelease.h>



Le 26/11/2022 à 15:07, Thomas Weißschuh a écrit :
> On 2022-11-26 07:36+0000, Christophe Leroy wrote:
>> Le 26/11/2022 à 06:10, Thomas Weißschuh a écrit :
>>> Commit 7ad4bd887d27 ("powerpc/book3e: get rid of #include <generated/compile.h>")
>>> removed the usage of the define UTS_VERSION but forgot to drop the
>>> include.
>>
>> What about:
>> arch/powerpc/platforms/52xx/efika.c
>> arch/powerpc/platforms/amigaone/setup.c
>> arch/powerpc/platforms/chrp/setup.c
>> arch/powerpc/platforms/powermac/bootx_init.c
>>
>> I believe you can do a lot more than what you did in your series.
> 
> The commit messages are wrong.
> They should have said UTS_RELEASE instead of UTS_VERSION.

Ah, ok. So your series is complete then:

$ git grep -L UTS_RELEASE `git grep -l "#include <generated/utsrelease.h>"`
Documentation/target/tcm_mod_builder.py
arch/powerpc/mm/nohash/kaslr_booke.c
drivers/base/firmware_loader/firmware.h
init/version.c

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>

> 
> Could the maintainers fix this up when applying?
> I also changed it locally so it will be fixed for v2.
> 
>> List of files using UTS_VERSION :
>>
>> $ git grep -l UTS_VERSION
>> [..]
> 
> Thomas