linux-kernel - Re: [PATCH] watchdog: iTCO_wdt: Report firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <acf780ec-11e4-bd1c-e931-c430f5e43edd@roeck-us.net>
Date:   Fri, 25 Nov 2022 16:34:43 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Thomas Weißschuh <linux@...ssschuh.net>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: iTCO_wdt: Report firmware_version

On 11/25/22 14:12, Thomas Weißschuh wrote:
> Synchronize the reported information in dmesg and the watchdog APIs.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/iTCO_wdt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
> index 34693f11385f..9b3c9f8b0b93 100644
> --- a/drivers/watchdog/iTCO_wdt.c
> +++ b/drivers/watchdog/iTCO_wdt.c
> @@ -437,11 +437,10 @@ static void iTCO_wdt_set_running(struct iTCO_wdt_private *p)
>    *	Kernel Interfaces
>    */
>   
> -static const struct watchdog_info ident = {
> +static struct watchdog_info ident = {
>   	.options =		WDIOF_SETTIMEOUT |
>   				WDIOF_KEEPALIVEPING |
>   				WDIOF_MAGICCLOSE,
> -	.firmware_version =	0,
>   	.identity =		DRV_NAME,
>   };
>   
> @@ -562,6 +561,7 @@ static int iTCO_wdt_probe(struct platform_device *pdev)
>   		break;
>   	}
>   
> +	ident.firmware_version = p->iTCO_version;
>   	p->wddev.info = &ident,
>   	p->wddev.ops = &iTCO_wdt_ops,
>   	p->wddev.bootstatus = 0;
> 
> base-commit: 0b1dcc2cf55ae6523c6fbd0d741b3ac28c9f4536