lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20221126162211.93322-1-mailhol.vincent@wanadoo.fr> Date: Sun, 27 Nov 2022 01:22:05 +0900 From: Vincent Mailhol <mailhol.vincent@...adoo.fr> To: linux-can@...r.kernel.org Cc: Marc Kleine-Budde <mkl@...gutronix.de>, linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, netdev@...r.kernel.org, linux-usb@...r.kernel.org, Saeed Mahameed <saeed@...nel.org>, Andrew Lunn <andrew@...n.ch>, Jiri Pirko <jiri@...dia.com>, Lukas Magel <lukas.magel@...teo.net>, Vincent Mailhol <mailhol.vincent@...adoo.fr> Subject: [PATCH v4 0/6] can: etas_es58x: report firmware, bootloader and hardware version The goal of this series is to report the firmware version, the bootloader version and the hardware revision of ETAS ES58x devices. These are already reported in the kernel log but this isn't best practice. Remove the kernel log and instead export all these through devlink. In addition, the firmware version is also reported through ethtool. --- * Changelog * v3 -> v4: * major rework to use devlink instead of sysfs following Andrew's comment. * split the series in 6 patches. * [PATCH 1/6] add Acked-by: Greg Kroah-Hartman v2 -> v3: * patch 2/3: do not spam the kernel log anymore with the product number. Instead parse the product information string, extract the firmware version, the bootloadar version and the hardware revision and export them through sysfs. * patch 2/3: rework the parsing in order not to need additional fields in struct es58x_parameters. * patch 3/3: only populate ethtool_drvinfo::fw_version because since commit edaf5df22cb8 ("ethtool: ethtool_get_drvinfo: populate drvinfo fields even if callback exits"), there is no need to populate ethtool_drvinfo::driver and ethtool_drvinfo::bus_info in the driver. v1 -> v2: * was a single patch. It is now a series of three patches. * add a first new patch to export usb_cache_string(). * add a second new patch to apply usb_cache_string() to existing code. * add missing check on product info string to prevent a buffer overflow. * add comma on the last entry of struct es58x_parameters. Vincent Mailhol (6): USB: core: export usb_cache_string() can: etas_es58x: add devlink support can: etas_es58x: export product information through devlink_ops::info_get() can: etas_es58x: remove es58x_get_product_info() can: etas_es58x: report the firmware version through ethtool Documentation: devlink: add devlink documentation for the etas_es58x driver .../networking/devlink/etas_es58x.rst | 33 +++ MAINTAINERS | 1 + drivers/net/can/usb/Kconfig | 1 + drivers/net/can/usb/etas_es58x/Makefile | 2 +- drivers/net/can/usb/etas_es58x/es58x_core.c | 85 +++---- drivers/net/can/usb/etas_es58x/es58x_core.h | 73 ++++++ .../net/can/usb/etas_es58x/es58x_devlink.c | 207 ++++++++++++++++++ drivers/usb/core/message.c | 1 + drivers/usb/core/usb.h | 1 - include/linux/usb.h | 1 + 10 files changed, 352 insertions(+), 53 deletions(-) create mode 100644 Documentation/networking/devlink/etas_es58x.rst create mode 100644 drivers/net/can/usb/etas_es58x/es58x_devlink.c -- 2.37.4
Powered by blists - more mailing lists