linux-kernel - Re: [PATCH mm] kasan: fail non-kasan KUnit tests on KASAN reports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+fCnZceUx+Vqj7nUPiLrexnmU11KkGGtJ3-9KfXm336e+cv3w@mail.gmail.com>
Date:   Sat, 26 Nov 2022 19:16:17 +0100
From:   Andrey Konovalov <andreyknvl@...il.com>
To:     David Gow <davidgow@...gle.com>
Cc:     Marco Elver <elver@...gle.com>,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Andrey Ryabinin <ryabinin.a.a@...il.com>,
        kasan-dev@...glegroups.com,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Andrey Konovalov <andreyknvl@...gle.com>,
        andrey.konovalov@...ux.dev
Subject: Re: [PATCH mm] kasan: fail non-kasan KUnit tests on KASAN reports

On Sat, Nov 26, 2022 at 7:15 PM <andrey.konovalov@...ux.dev> wrote:
>
> From: Andrey Konovalov <andreyknvl@...gle.com>
>
> After the recent changes done to KUnit-enabled KASAN tests, non-KASAN KUnit
> tests stopped being failed when KASAN report is detected.
>
> Recover that property by failing the currently running non-KASAN KUnit test
> when KASAN detects and prints a report for a bad memory access.
>
> Note that if the bad accesses happened in a kernel thread that doesn't
> have a reference to the currently running KUnit-test available via
> current->kunit_test, the test won't be failed. This is a limitation of
> KUnit, which doesn't yet provide a thread-agnostic way to find the
> reference to the currenly running test.
>
> Fixes: 49d9977ac909 ("kasan: check CONFIG_KASAN_KUNIT_TEST instead of CONFIG_KUNIT")
> Fixes: 7f29493ba529 ("kasan: switch kunit tests to console tracepoints")
> Signed-off-by: Andrey Konovalov <andreyknvl@...gle.com>

Hi David,

Could you please check whether this patch resolves the issue with
non-KASAN KUnit tests for you?

Thank you!