linux-kernel - Re: [PATCH 4/4] media: i2c: s5c73m3: switch to using gpiod API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaczw75FX17m96s6zS1ng+rp8QXwW2=n8HZ5OKYH6xpsA@mail.gmail.com>
Date:   Sat, 26 Nov 2022 22:49:27 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Hans Verkuil <hverkuil@...all.nl>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH 4/4] media: i2c: s5c73m3: switch to using gpiod API

On Sat, Nov 26, 2022 at 11:34 AM Hans Verkuil <hverkuil@...all.nl> wrote:
> On 17/11/2022 10:06, Linus Walleij wrote:
> > On Tue, Nov 15, 2022 at 11:11 PM Dmitry Torokhov
> > <dmitry.torokhov@...il.com> wrote:
> >
> >> This patch switches the driver away from legacy gpio/of_gpio API to
> >> gpiod API, and removes use of of_get_named_gpio_flags() which I want to
> >> make private to gpiolib.
> >>
> >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> >
> > Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
>
> There are now two patches that do this switch to using the gpiod API:
> this one, and one from you:

Ooops we stepped on each others' toes again. Dmitry & I really like
to fix these drivers :D sorry about that.

> https://patchwork.linuxtv.org/project/linux-media/patch/20221108100604.1500909-1-linus.walleij@linaro.org/
>
> Any preference?

Not really, take the one you like best, they look functionally equivalent to me,
just slightly different stylistic choices.

Yours,
Linus Walleij