linux-kernel - Re: [PATCH 3/3] init/version.c: remove #include <generated/utsversion.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAREVSp_5d1SaFOLyBHJJrJ6zE_qxSYWAFFnfoz3d0w3-Q@mail.gmail.com>
Date:   Sun, 27 Nov 2022 07:18:11 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Thomas Weißschuh <linux@...ssschuh.net>
Cc:     Luis Chamberlain <mcgrof@...nel.org>,
        Russ Weight <russell.h.weight@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>
Subject: Re: [PATCH 3/3] init/version.c: remove #include <generated/utsversion.h>

On Sat, Nov 26, 2022 at 2:10 PM Thomas Weißschuh <linux@...ssschuh.net> wrote:
>
> Commit 2df8220cc511 ("kbuild: build init/built-in.a just once") moved
> the usage of the define UTS_VERSION to the file version-timestamp.c.

With s/UTS_VERSION/UTS_RELEASE/,


Reviewed-by: Masahiro Yamada <masahiroy@...nel.org>

>
> version-timestamp.c in turn is included from version.c but already
> includes utsversion.h itself properly.
>
> The unneeded include of utsversion.h from version.c can be dropped.
>
> Fixes: 2df8220cc511 ("kbuild: build init/built-in.a just once")
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> ---
>  init/version.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/init/version.c b/init/version.c
> index 01d4ab05f0ba..f117921811b4 100644
> --- a/init/version.c
> +++ b/init/version.c
> @@ -15,7 +15,6 @@
>  #include <linux/printk.h>
>  #include <linux/uts.h>
>  #include <linux/utsname.h>
> -#include <generated/utsrelease.h>
>  #include <linux/proc_ns.h>
>
>  static int __init early_hostname(char *arg)
> --
> 2.38.1
>


-- 
Best Regards
Masahiro Yamada