linux-kernel - Re: [PATCH v1 1/1] modpost: Mark uuid_le type to be suitable only for MEI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAThgfr2p5G9eNViw48ha1+505xNAOeadiVp1_gqq9CABg@mail.gmail.com>
Date:   Sun, 27 Nov 2022 08:11:09 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nicolas Schier <nicolas@...sle.eu>
Subject: Re: [PATCH v1 1/1] modpost: Mark uuid_le type to be suitable only for MEI

On Fri, Nov 25, 2022 at 7:12 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> The uuid_le type is used only in MEI ABI, do not advertise it for others.
> While at it, comment out that UUID types are not to be used in a new code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>

Applied to linux-kbuild.
Thanks.



> If you confused by acrn user of the uuid_le type, the patch to fix that
> is pending for v6.2 as well 1dbb4f0235a4 ("virt: acrn: Mark the uuid
> field as unused"). Nevertheless this patch doesn't break the things and
> hence can go independently to the respective tree.
>
>  scripts/mod/file2alias.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
> index 7df23905fdf1..91c2e7ba5e52 100644
> --- a/scripts/mod/file2alias.c
> +++ b/scripts/mod/file2alias.c
> @@ -34,19 +34,23 @@ typedef Elf64_Addr  kernel_ulong_t;
>  typedef uint32_t       __u32;
>  typedef uint16_t       __u16;
>  typedef unsigned char  __u8;
> +
> +/* UUID types for backward compatibility, don't use in new code */
>  typedef struct {
>         __u8 b[16];
>  } guid_t;
>
> -/* backwards compatibility, don't use in new code */
> -typedef struct {
> -       __u8 b[16];
> -} uuid_le;
>  typedef struct {
>         __u8 b[16];
>  } uuid_t;
> +
>  #define        UUID_STRING_LEN         36
>
> +/* MEI UUID type, don't use anywhere else */
> +typedef struct {
> +       __u8 b[16];
> +} uuid_le;
> +
>  /* Big exception to the "don't include kernel headers into userspace, which
>   * even potentially has different endianness and word sizes, since
>   * we handle those differences explicitly below */
> --
> 2.35.1
>


-- 
Best Regards
Masahiro Yamada