linux-kernel - Re: [PATCH -next 1/1] mm/memory-failure.c: Cleanup in unpoison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5474d574-08e1-f630-7ab2-f688e7e90e64@huawei.com>
Date:   Sat, 26 Nov 2022 09:41:22 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Wupeng Ma <mawupeng1@...wei.com>
CC:     <akpm@...ux-foundation.org>, <pizhenwei@...edance.com>,
        <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
        HORIGUCHI NAOYA <naoya.horiguchi@....com>
Subject: Re: [PATCH -next 1/1] mm/memory-failure.c: Cleanup in unpoison_memory

On 2022/11/25 14:54, Wupeng Ma wrote:
> From: Ma Wupeng <mawupeng1@...wei.com>
> 
> If freeit it true, the value of ret must be zero, there is no need to

s/it/is/

> check the value of freeit after label unlock_mutex.
> 
> We can drop variable freeit to do this cleanup.
> 
> Signed-off-by: Ma Wupeng <mawupeng1@...wei.com>

Reviewed-by: Miaohe Lin <linmiaohe@...wei.com>

Thanks,
Miaohe Lin