linux-kernel - Re: [PATCH] hwmon: (hih6130) Modify mismatched function name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e3017eda-3764-4ff0-71fc-0f33f5ad8085@roeck-us.net>
Date:   Sun, 27 Nov 2022 07:01:47 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, jdelvare@...e.com
Cc:     linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] hwmon: (hih6130) Modify mismatched function name

On 11/27/22 05:43, Jiapeng Chong wrote:
> No functional modification involved.
> 
> drivers/hwmon/hih6130.c:185: warning: expecting prototype for hih6130_show_humidity(). Prototype was for hih6130_humidity_show() instead.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3264
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

NACK. We don't start changing function names because some robot
thinks we should. Please do not submit such patches against the hwmon
or watchdog subsystems.

Guenter

> ---
>   drivers/hwmon/hih6130.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/hih6130.c b/drivers/hwmon/hih6130.c
> index d9394e19fea8..764e6e185d98 100644
> --- a/drivers/hwmon/hih6130.c
> +++ b/drivers/hwmon/hih6130.c
> @@ -172,7 +172,7 @@ static ssize_t hih6130_temperature_show(struct device *dev,
>   }
>   
>   /**
> - * hih6130_show_humidity() - show humidity measurement value in sysfs
> + * hih6130_humidity_show() - show humidity measurement value in sysfs
>    * @dev: device
>    * @attr: device attribute
>    * @buf: sysfs buffer (PAGE_SIZE) where measurement values are written to