linux-kernel - Re: [PATCH] irqchip: Allow test compilation of Broadcom drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9c403170-4493-d960-b470-ba337dae893d@gmail.com>
Date:   Sun, 27 Nov 2022 12:28:39 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Marc Zyngier <maz@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] irqchip: Allow test compilation of Broadcom drivers



On 11/26/2022 5:26 AM, Marc Zyngier wrote:
> On Mon, 24 Oct 2022 23:27:39 +0100,
> Florian Fainelli <f.fainelli@...il.com> wrote:
>>
>> Allow test compilation of the Broadcom irqchip drivers by adding a
>> COMPILE_TEST dependency.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
>> ---
>>   drivers/irqchip/Kconfig | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
>> index 7ef9f5e696d3..e4b2ec9b2450 100644
>> --- a/drivers/irqchip/Kconfig
>> +++ b/drivers/irqchip/Kconfig
>> @@ -116,7 +116,7 @@ config BCM6345_L1_IRQ
>>   
>>   config BCM7038_L1_IRQ
>>   	tristate "Broadcom STB 7038-style L1/L2 interrupt controller driver"
>> -	depends on ARCH_BRCMSTB || BMIPS_GENERIC
>> +	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> 
> Do we actually need all this churn now that OF is user-selectable (see
> 0166dc11be91)?

Seems to me that we would since that allows people to choose the 
building of these drivers rather than lift the dependencies and replace 
it with:

depends on OF

as this would prompt many users about drivers they do not care about.
-- 
Florian