linux-kernel - Re: [PATCH 1/2] ASoC: tas5805m: rework to avoid scheduling while atomic.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202211271634.gGggqMdS-lkp@intel.com>
Date:   Sun, 27 Nov 2022 16:49:42 +0800
From:   kernel test robot <lkp@...el.com>
To:     Daniel Beer <daniel.beer@...rinstitute.com>,
        alsa-devel@...a-project.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Daniel Beer <daniel.beer@...rinstitute.com>,
        Andy Liu <andy-liu@...com>, Mark Brown <broonie@...nel.org>,
        Derek Simkowiak <derek.simkowiak@...rinstitute.com>
Subject: Re: [PATCH 1/2] ASoC: tas5805m: rework to avoid scheduling while
 atomic.

Hi Daniel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on linus/master v6.1-rc6 next-20221125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Daniel-Beer/ASoC-tas5805m-rework-to-avoid-scheduling-while-atomic/20221127-152934
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link:    https://lore.kernel.org/r/638311c1.170a0220.5d7c0.85d6%40mx.google.com
patch subject: [PATCH 1/2] ASoC: tas5805m: rework to avoid scheduling while atomic.
config: m68k-allyesconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/834b4c86b998cb6b51da6d2ab3f3d2110e17c6ab
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Daniel-Beer/ASoC-tas5805m-rework-to-avoid-scheduling-while-atomic/20221127-152934
        git checkout 834b4c86b998cb6b51da6d2ab3f3d2110e17c6ab
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash sound/soc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   sound/soc/codecs/tas5805m.c: In function 'tas5805m_vol_put':
>> sound/soc/codecs/tas5805m.c:251:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     251 |         int ret = 0;
         |             ^~~


vim +/ret +251 sound/soc/codecs/tas5805m.c

   243	
   244	static int tas5805m_vol_put(struct snd_kcontrol *kcontrol,
   245				    struct snd_ctl_elem_value *ucontrol)
   246	{
   247		struct snd_soc_component *component =
   248			snd_soc_kcontrol_component(kcontrol);
   249		struct tas5805m_priv *tas5805m =
   250			snd_soc_component_get_drvdata(component);
 > 251		int ret = 0;
   252	
   253		if (!(volume_is_valid(ucontrol->value.integer.value[0]) &&
   254		      volume_is_valid(ucontrol->value.integer.value[1])))
   255			return -EINVAL;
   256	
   257		mutex_lock(&tas5805m->lock);
   258		if (tas5805m->vol[0] != ucontrol->value.integer.value[0] ||
   259		    tas5805m->vol[1] != ucontrol->value.integer.value[1]) {
   260			tas5805m->vol[0] = ucontrol->value.integer.value[0];
   261			tas5805m->vol[1] = ucontrol->value.integer.value[1];
   262			dev_dbg(component->dev, "set vol=%d/%d (is_powered=%d)\n",
   263				tas5805m->vol[0], tas5805m->vol[1],
   264				tas5805m->is_powered);
   265			if (tas5805m->is_powered)
   266				tas5805m_refresh(tas5805m);
   267			ret = 1;
   268		}
   269		mutex_unlock(&tas5805m->lock);
   270	
   271		return 0;
   272	}
   273	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (282773 bytes)