| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202211272043.vriqj1dJ-lkp@intel.com>
Date: Sun, 27 Nov 2022 20:11:38 +0800
From: kernel test robot <lkp@...el.com>
To: Vincent Mailhol <mailhol.vincent@...adoo.fr>,
Jiri Pirko <jiri@...dia.com>, netdev@...r.kernel.org,
Jakub Kicinski <kuba@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
Boris Brezillon <bbrezillon@...nel.org>,
Arnaud Ebalard <arno@...isbad.org>,
Srujana Challa <schalla@...vell.com>,
Kurt Kanzenbach <kurt@...utronix.de>,
Andrew Lunn <andrew@...n.ch>,
Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
Michael Chan <michael.chan@...adcom.com>,
Ioana Ciornei <ioana.ciornei@....com>,
Dimitris Michailidis <dmichail@...gible.com>,
Yisen Zhuang <yisen.zhuang@...wei.com>,
Salil Mehta <salil.mehta@...wei.com>,
Jesse Brandeburg <jesse.brandeburg@...el.com>,
Tony Nguyen <anthony.l.nguyen@...el.com>,
Sunil Goutham <sgoutham@...vell.com>,
Linu Cherian <lcherian@...vell.com>,
Geetha sowjanya <gakula@...vell.com>,
Jerin Jacob <jerinj@...vell.com>,
hariprasad <hkelam@...vell.com>,
Subbaraya Sundeep <sbhatta@...vell.com>,
Taras Chornyi <tchornyi@...vell.com>,
Saeed Mahameed <saeedm@...dia.com>,
Leon Romanovsky <leon@...nel.org>
Subject: Re: [PATCH net-next v2 4/5] net: devlink: remove
devlink_info_driver_name_put()
Hi Vincent,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Vincent-Mailhol/mlxsw-minimal-fix-mlxsw_m_module_get_drvinfo-to-correctly-report-driver-name/20221127-171657
patch link: https://lore.kernel.org/r/20221127081604.5242-5-mailhol.vincent%40wanadoo.fr
patch subject: [PATCH net-next v2 4/5] net: devlink: remove devlink_info_driver_name_put()
config: x86_64-allyesconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/32018f68afc2b6dca866e1cdf0e5417ef4413d75
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Vincent-Mailhol/mlxsw-minimal-fix-mlxsw_m_module_get_drvinfo-to-correctly-report-driver-name/20221127-171657
git checkout 32018f68afc2b6dca866e1cdf0e5417ef4413d75
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
drivers/net/ethernet/mellanox/mlxsw/core.c: In function 'mlxsw_devlink_info_get':
>> drivers/net/ethernet/mellanox/mlxsw/core.c:1463:15: error: implicit declaration of function 'devlink_info_driver_name_put'; did you mean 'devlink_info_serial_number_put'? [-Werror=implicit-function-declaration]
1463 | err = devlink_info_driver_name_put(req,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| devlink_info_serial_number_put
cc1: some warnings being treated as errors
vim +1463 drivers/net/ethernet/mellanox/mlxsw/core.c
1ceecc88d29bbb Jiri Pirko 2016-04-14 1450
a9c8336f65446b Shalom Toledo 2019-04-08 1451 static int
a9c8336f65446b Shalom Toledo 2019-04-08 1452 mlxsw_devlink_info_get(struct devlink *devlink, struct devlink_info_req *req,
a9c8336f65446b Shalom Toledo 2019-04-08 1453 struct netlink_ext_ack *extack)
a9c8336f65446b Shalom Toledo 2019-04-08 1454 {
a9c8336f65446b Shalom Toledo 2019-04-08 1455 struct mlxsw_core *mlxsw_core = devlink_priv(devlink);
92f165ec5b1e76 Vincent Mailhol 2022-11-27 1456 struct device *dev = mlxsw_core->bus_info->dev;
a9c8336f65446b Shalom Toledo 2019-04-08 1457 char fw_info_psid[MLXSW_REG_MGIR_FW_INFO_PSID_SIZE];
a9c8336f65446b Shalom Toledo 2019-04-08 1458 u32 hw_rev, fw_major, fw_minor, fw_sub_minor;
a9c8336f65446b Shalom Toledo 2019-04-08 1459 char mgir_pl[MLXSW_REG_MGIR_LEN];
a9c8336f65446b Shalom Toledo 2019-04-08 1460 char buf[32];
a9c8336f65446b Shalom Toledo 2019-04-08 1461 int err;
a9c8336f65446b Shalom Toledo 2019-04-08 1462
a9c8336f65446b Shalom Toledo 2019-04-08 @1463 err = devlink_info_driver_name_put(req,
92f165ec5b1e76 Vincent Mailhol 2022-11-27 1464 dev_driver_string(dev->parent));
a9c8336f65446b Shalom Toledo 2019-04-08 1465 if (err)
a9c8336f65446b Shalom Toledo 2019-04-08 1466 return err;
a9c8336f65446b Shalom Toledo 2019-04-08 1467
a9c8336f65446b Shalom Toledo 2019-04-08 1468 mlxsw_reg_mgir_pack(mgir_pl);
a9c8336f65446b Shalom Toledo 2019-04-08 1469 err = mlxsw_reg_query(mlxsw_core, MLXSW_REG(mgir), mgir_pl);
a9c8336f65446b Shalom Toledo 2019-04-08 1470 if (err)
a9c8336f65446b Shalom Toledo 2019-04-08 1471 return err;
a9c8336f65446b Shalom Toledo 2019-04-08 1472 mlxsw_reg_mgir_unpack(mgir_pl, &hw_rev, fw_info_psid, &fw_major,
a9c8336f65446b Shalom Toledo 2019-04-08 1473 &fw_minor, &fw_sub_minor);
a9c8336f65446b Shalom Toledo 2019-04-08 1474
a9c8336f65446b Shalom Toledo 2019-04-08 1475 sprintf(buf, "%X", hw_rev);
a9c8336f65446b Shalom Toledo 2019-04-08 1476 err = devlink_info_version_fixed_put(req, "hw.revision", buf);
a9c8336f65446b Shalom Toledo 2019-04-08 1477 if (err)
a9c8336f65446b Shalom Toledo 2019-04-08 1478 return err;
a9c8336f65446b Shalom Toledo 2019-04-08 1479
7dafcc4c9dfb41 Jiri Pirko 2021-05-26 1480 err = devlink_info_version_fixed_put(req,
7dafcc4c9dfb41 Jiri Pirko 2021-05-26 1481 DEVLINK_INFO_VERSION_GENERIC_FW_PSID,
7dafcc4c9dfb41 Jiri Pirko 2021-05-26 1482 fw_info_psid);
a9c8336f65446b Shalom Toledo 2019-04-08 1483 if (err)
a9c8336f65446b Shalom Toledo 2019-04-08 1484 return err;
a9c8336f65446b Shalom Toledo 2019-04-08 1485
a9c8336f65446b Shalom Toledo 2019-04-08 1486 sprintf(buf, "%d.%d.%d", fw_major, fw_minor, fw_sub_minor);
a9c8336f65446b Shalom Toledo 2019-04-08 1487 err = devlink_info_version_running_put(req, "fw.version", buf);
a9c8336f65446b Shalom Toledo 2019-04-08 1488 if (err)
a9c8336f65446b Shalom Toledo 2019-04-08 1489 return err;
a9c8336f65446b Shalom Toledo 2019-04-08 1490
f55c998c274e3b Jiri Pirko 2021-05-26 1491 return devlink_info_version_running_put(req,
f55c998c274e3b Jiri Pirko 2021-05-26 1492 DEVLINK_INFO_VERSION_GENERIC_FW,
f55c998c274e3b Jiri Pirko 2021-05-26 1493 buf);
a9c8336f65446b Shalom Toledo 2019-04-08 1494 }
a9c8336f65446b Shalom Toledo 2019-04-08 1495
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (292021 bytes)
Powered by blists - more mailing lists