[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <877czfujdj.fsf@ubik.fi.intel.com>
Date: Mon, 28 Nov 2022 18:35:52 +0200
From: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To: Rob Herring <robh@...nel.org>, Will Deacon <will@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Ingo Molnar <mingo@...hat.com>
Cc: Namhyung Kim <namhyung@...nel.org>, Jiri Olsa <jolsa@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Catalin Marinas <catalin.marinas@....com>,
Marc Zyngier <maz@...nel.org>,
Oliver Upton <oliver.upton@...ux.dev>,
Suzuki K Poulose <suzuki.poulose@....com>,
James Morse <james.morse@....com>,
Alexandru Elisei <alexandru.elisei@....com>,
kvmarm@...ts.linux.dev, linux-perf-users@...r.kernel.org,
linux-kernel@...r.kernel.org, James Clark <james.clark@....com>,
Mark Brown <broonie@...nel.org>,
linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.cs.columbia.edu,
alexander.shishkin@...ux.intel.com
Subject: Re: [PATCH v3 7/8] perf: Add perf_event_attr::config3
Rob Herring <robh@...nel.org> writes:
> On Fri, Nov 18, 2022 at 10:49 AM Will Deacon <will@...nel.org> wrote:
>>
>> On Fri, Nov 04, 2022 at 10:55:07AM -0500, Rob Herring wrote:
>> > @@ -515,6 +516,8 @@ struct perf_event_attr {
>> > * truncated accordingly on 32 bit architectures.
>> > */
>> > __u64 sig_data;
>> > +
>> > + __u64 config3; /* extension of config2 */
>>
>> I need an ack from the perf core maintainers before I can take this.
>
> Peter, Arnaldo, Ingo,
>
> Can I get an ack on this please.
It appears that PMUs that don't use config{1,2} and now config3 allow
them to be whatever without any validation, whereas in reality we should
probably -EINVAL in those cases. Should something be done about that?
Regards,
--
Alex
Powered by blists - more mailing lists