linux-kernel - Re: [PATCH 6/6] composefs: Add kconfig and build support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Nov 2022 01:28:59 +0800
From:   kernel test robot <lkp@...el.com>
To:     Alexander Larsson <alexl@...hat.com>, linux-fsdevel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        gscrivan@...hat.com, alexl@...hat.com
Subject: Re: [PATCH 6/6] composefs: Add kconfig and build support

Hi Alexander,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on fscrypt/fsverity]
[also build test ERROR on linus/master v6.1-rc7 next-20221128]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alexander-Larsson/Composefs-an-opportunistically-sharing-verified-image-filesystem/20221128-192140
base:   https://git.kernel.org/pub/scm/fs/fscrypt/fscrypt.git fsverity
patch link:    https://lore.kernel.org/r/a0524f492d2ac64b99f3de6ea2b27249a4bcadad.1669631086.git.alexl%40redhat.com
patch subject: [PATCH 6/6] composefs: Add kconfig and build support
config: sh-allmodconfig
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b1d98075a6a519fa9405dd2cd273ed2e00f12266
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Alexander-Larsson/Composefs-an-opportunistically-sharing-verified-image-filesystem/20221128-192140
        git checkout b1d98075a6a519fa9405dd2cd273ed2e00f12266
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash fs/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   fs/composefs/cfs.c: In function 'cfs_mmu_get_unmapped_area':
>> fs/composefs/cfs.c:686:27: error: 'struct mm_struct' has no member named 'get_unmapped_area'
     686 |         return current->mm->get_unmapped_area(file, addr, len, pgoff, flags);
         |                           ^~
   fs/composefs/cfs.c:687:1: error: control reaches end of non-void function [-Werror=return-type]
     687 | }
         | ^
   fs/composefs/cfs.c: At top level:
   fs/composefs/cfs.c:58:42: warning: 'generic_file_vm_ops' defined but not used [-Wunused-const-variable=]
      58 | static const struct vm_operations_struct generic_file_vm_ops;
         |                                          ^~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +686 fs/composefs/cfs.c

0f354cef5ce30b Alexander Larsson 2022-11-28  674  
0f354cef5ce30b Alexander Larsson 2022-11-28  675  static unsigned long cfs_mmu_get_unmapped_area(struct file *file,
0f354cef5ce30b Alexander Larsson 2022-11-28  676  					       unsigned long addr,
0f354cef5ce30b Alexander Larsson 2022-11-28  677  					       unsigned long len,
0f354cef5ce30b Alexander Larsson 2022-11-28  678  					       unsigned long pgoff,
0f354cef5ce30b Alexander Larsson 2022-11-28  679  					       unsigned long flags)
0f354cef5ce30b Alexander Larsson 2022-11-28  680  {
0f354cef5ce30b Alexander Larsson 2022-11-28  681  	struct file *realfile = file->private_data;
0f354cef5ce30b Alexander Larsson 2022-11-28  682  
0f354cef5ce30b Alexander Larsson 2022-11-28  683  	if (realfile == &empty_file)
0f354cef5ce30b Alexander Larsson 2022-11-28  684  		return 0;
0f354cef5ce30b Alexander Larsson 2022-11-28  685  
0f354cef5ce30b Alexander Larsson 2022-11-28 @686  	return current->mm->get_unmapped_area(file, addr, len, pgoff, flags);
0f354cef5ce30b Alexander Larsson 2022-11-28  687  }
0f354cef5ce30b Alexander Larsson 2022-11-28  688  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (244095 bytes)