linux-kernel - Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Nov 2022 17:41:14 +0000
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Doug Anderson <dianders@...omium.org>,
        楊宗翰 <ecs.taipeikernel@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Bob Moragues <moragues@...omium.org>,
        Stephen Boyd <swboyd@...omium.org>, Harvey <hunge@...gle.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, Gavin.Lee@....com.tw,
        Darren.Chen@....com.tw, Abner.Yen@....com.tw, Vicy.Lee@....com.tw,
        Jason.Huang@....com.tw
Subject: Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie

On Mon, Nov 28, 2022 at 06:22:39PM +0100, Krzysztof Kozlowski wrote:
> On 28/11/2022 16:56, Doug Anderson wrote:
> > Hi,
> > 
> > On Thu, Nov 24, 2022 at 3:27 AM Krzysztof Kozlowski
> > <krzysztof.kozlowski@...aro.org> wrote:
> >>
> >> On 24/11/2022 12:20, 楊宗翰 wrote:
> >>> Hi Krzysztof, Matthias,
> >>>
> >>> How to use "get_maintainers.pl"?
> >>>
> >>> I find this script in path "<MyCodebase>/kernel/v5.15/script", and output
> >>
> >> This looks like v5.15 kernel which is heavily outdated. Please never
> >> work on such kernels when interacting with upstream. The rule is you
> >> work on either last mainline kernel (v6.1-rc6), maintainers for-next
> >> branch (you should know who is the maintainer of subsystem you submit
> >> to, get_maintainers.pl gives this information) or on moderately recent
> >> linux-next. For bigger patchsets there might be exceptions for these
> >> rules, but it's not the case here.
> > 
> > Just to add context here, it's a fairly standard workflow for ChromeOS
> > kernel engineers to work in a "versioned" kernel directory but still
> > checkout and work with the upstream kernel. I'm sure it's confusing to
> > anyone not used to working with the ChromeOS source tree and build
> > system. Sorry! :( So the fact that Owen is in a directory called
> > "v5.15" doesn't mean that he's actually working with the v5.15 kernel.
> > The fact that Bjorn's address is correct in his CC list implies to me
> > that he's actually got a proper upstream kernel.
> > 
> > I had previously [0] instructed Owen to send against Bjorn's tree, so
> > hopefully it's correct.
> 
> If it was on Bjorn's tree, get_maintainers.pl would not produce such result:
> 
> ---
> Series-to: LKML <linux-kernel@...r.kernel.org>
> Series-cc: Douglas Anderson <dianders@...omium.org>
> Series-cc: Bob Moragues <moragues@...omium.org>
> Series-cc: Harvey <hunge@...gle.com>
> Series-cc: Stephen Boyd <swboyd@...omium.org>
> Series-cc: Matthias Kaehlcke <mka@...omium.org>
> Series-cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

These look like manual entries for patman

> or this:
> 
> ---
> owen@...ldsvr-HP-ProDesk-600-G4-MT:~/chromebook_zombie_os/src/third_party/kernel/v5.15$
> perl scripts/get_maintainer.pl -f MAINTAINERS --email
> linux-kernel@...r.kernel.org (open list)
> ---
> 
> as Owen indicated earlier. They are either incomplete or not correct.
> 
> Of course I don't know whether the base tree is the problem or usage of
> get_maintainers.pl...

That looks like an operator error, the above command produces the same result with
an upstream tree.

Issue one is the use of '-f' which seems to expect a file with a list of e-mail
addresses, which MAINTAINERS is not. The second issue is that no patch file or
directory is specified.