[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221128124513.76392c3d@gandalf.local.home>
Date: Mon, 28 Nov 2022 12:45:13 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Vincent MAILHOL <mailhol.vincent@...adoo.fr>
Cc: kirill.shutemov@...ux.intel.com, bp@...en8.de,
dave.hansen@...ux.intel.com, hpa@...or.com, jpoimboe@...nel.org,
linux-kernel@...r.kernel.org, mingo@...hat.com,
pbonzini@...hat.com, sathyanarayanan.kuppuswamy@...ux.intel.com,
seanjc@...gle.com, tglx@...utronix.de, viro@...iv.linux.org.uk,
x86@...nel.org
Subject: Re: [PATCH] x86/asm: Remove unused COMPILE_OFFSETS macro from
asm-offsets.c
On Mon, 28 Nov 2022 20:30:35 +0900
Vincent MAILHOL <mailhol.vincent@...adoo.fr> wrote:
> > If you are sure <asm/ftrace.h> is never included from asm-offsets.c,
> > remove #ifndef COMPILE_OFFSETS too.
>
> It is never included from asm-offsets.c but it is still used by
> kvm-asm-offsets.c:
> https://elixir.bootlin.com/linux/v6.1-rc7/source/arch/x86/kvm/kvm-asm-offsets.c#L7
IIRC, the reason for adding that was because that logic was screwing up
asm-offsets.c. I'm not sure it screws up kvm-asm-offsets.c though.
This is one of those cases I wish I commented that code better :-/
-- Steve
Powered by blists - more mailing lists